kotovalexarian-likes-gitlab
/
gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Fix page refresh in retry_until

This commit is contained in:
Sanad Liaquat 2019-07-12 11:31:49 +05:00
parent 0b71325dc0
commit f4a4f6e28a
3 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
qa/qa/page/base.rb
View File

@ -26,7 +26,7 @@ module QA
end
def retry_until(max_attempts: 3, reload: false, sleep_interval: 0)
QA::Support::Retrier.retry_until(max_attempts: max_attempts, reload: reload, sleep_interval: sleep_interval) do
QA::Support::Retrier.retry_until(max_attempts: max_attempts, reload_page: (reload && self), sleep_interval: sleep_interval) do
yield
end
end

2
qa/qa/specs/features/browser_ui/1_manage/login/log_in_spec.rb
View File

@ -11,7 +11,7 @@ module QA
expect(menu).to have_personal_area
end
Support::Retrier.retry_until(reload: false, sleep_interval: 0.5) do
Support::Retrier.retry_until(sleep_interval: 0.5) do
Page::Main::Menu.perform(&:sign_out)
Page::Main::Login.perform(&:has_sign_in_tab?)

6
qa/qa/support/retrier.rb
View File

@ -24,8 +24,8 @@ module QA
end
end
def retry_until(max_attempts: 3, reload: false, sleep_interval: 0)
QA::Runtime::Logger.debug("with retry_until: max_attempts #{max_attempts}; sleep_interval #{sleep_interval}; reload:#{reload}")
def retry_until(max_attempts: 3, reload_page: nil, sleep_interval: 0)
QA::Runtime::Logger.debug("with retry_until: max_attempts #{max_attempts}; sleep_interval #{sleep_interval}; reload_page:#{reload_page}")
attempts = 0
while attempts < max_attempts
@ -35,7 +35,7 @@ module QA
sleep sleep_interval
refresh if reload
reload_page.refresh if reload_page
attempts += 1
end