Test etag cache key changing value

This commit is contained in:
Z.J. van de Weg 2017-05-30 23:56:26 +02:00
parent 7ec8969285
commit f4aa01053e
2 changed files with 19 additions and 2 deletions

View File

@ -202,11 +202,16 @@ class Environment < ActiveRecord::Base
def expire_etag_cache
Gitlab::EtagCaching::Store.new.tap do |store|
store.touch(Gitlab::Routing.url_helpers
.namespace_project_environments_path(project.namespace, project))
store.touch(etag_cache_key)
end
end
def etag_cache_key
Gitlab::Routing.url_helpers.namespace_project_environments_path(
project.namespace,
project)
end
private
# Slugifying a name may remove the uniqueness guarantee afforded by it being

View File

@ -42,6 +42,18 @@ describe Environment, models: true do
end
end
describe '#expire_etag_cache' do
let(:store) { Gitlab::EtagCaching::Store.new }
it 'changes the cached value' do
old_value = store.get(environment.etag_cache_key)
environment.stop
expect(store.get(environment.etag_cache_key)).not_to eq(old_value)
end
end
describe '#nullify_external_url' do
it 'replaces a blank url with nil' do
env = build(:environment, external_url: "")