Remove unused button classes `btn-create` and `comment-btn`
This commit is contained in:
parent
9b9b9b9161
commit
f4e2bd1703
|
@ -370,7 +370,7 @@ append-right-10 comment-type-dropdown js-comment-type-dropdown droplab-dropdown"
|
||||||
>
|
>
|
||||||
<button
|
<button
|
||||||
:disabled="isSubmitButtonDisabled"
|
:disabled="isSubmitButtonDisabled"
|
||||||
class="btn btn-create comment-btn js-comment-button js-comment-submit-button
|
class="btn btn-success js-comment-button js-comment-submit-button
|
||||||
qa-comment-button"
|
qa-comment-button"
|
||||||
type="submit"
|
type="submit"
|
||||||
@click.prevent="handleSave();"
|
@click.prevent="handleSave();"
|
||||||
|
@ -381,7 +381,7 @@ append-right-10 comment-type-dropdown js-comment-type-dropdown droplab-dropdown"
|
||||||
:disabled="isSubmitButtonDisabled"
|
:disabled="isSubmitButtonDisabled"
|
||||||
name="button"
|
name="button"
|
||||||
type="button"
|
type="button"
|
||||||
class="btn comment-btn note-type-toggle js-note-new-discussion dropdown-toggle qa-note-dropdown"
|
class="btn btn-success note-type-toggle js-note-new-discussion dropdown-toggle qa-note-dropdown"
|
||||||
data-display="static"
|
data-display="static"
|
||||||
data-toggle="dropdown"
|
data-toggle="dropdown"
|
||||||
aria-label="Open comment type dropdown"
|
aria-label="Open comment type dropdown"
|
||||||
|
|
|
@ -1,10 +1,6 @@
|
||||||
/**
|
/**
|
||||||
* Note Form
|
* Note Form
|
||||||
*/
|
*/
|
||||||
.comment-btn {
|
|
||||||
@extend .btn-success;
|
|
||||||
}
|
|
||||||
|
|
||||||
.diff-file .diff-content {
|
.diff-file .diff-content {
|
||||||
tr.line_holder:hover > td .line_note_link {
|
tr.line_holder:hover > td .line_note_link {
|
||||||
opacity: 1;
|
opacity: 1;
|
||||||
|
@ -386,7 +382,7 @@ table {
|
||||||
}
|
}
|
||||||
|
|
||||||
.comment-type-dropdown {
|
.comment-type-dropdown {
|
||||||
.comment-btn {
|
.btn-success {
|
||||||
width: auto;
|
width: auto;
|
||||||
}
|
}
|
||||||
|
|
||||||
|
@ -417,7 +413,7 @@ table {
|
||||||
width: 100%;
|
width: 100%;
|
||||||
margin-bottom: 10px;
|
margin-bottom: 10px;
|
||||||
|
|
||||||
.comment-btn {
|
.btn-success {
|
||||||
flex-grow: 1;
|
flex-grow: 1;
|
||||||
flex-shrink: 0;
|
flex-shrink: 0;
|
||||||
width: auto;
|
width: auto;
|
||||||
|
|
|
@ -1,10 +1,10 @@
|
||||||
- noteable_name = @note.noteable.human_class_name
|
- noteable_name = @note.noteable.human_class_name
|
||||||
|
|
||||||
.float-left.btn-group.append-right-10.droplab-dropdown.comment-type-dropdown.js-comment-type-dropdown
|
.float-left.btn-group.append-right-10.droplab-dropdown.comment-type-dropdown.js-comment-type-dropdown
|
||||||
%input.btn.btn-nr.btn-success.comment-btn.js-comment-button.js-comment-submit-button{ type: 'submit', value: _('Comment') }
|
%input.btn.btn-nr.btn-success.js-comment-button.js-comment-submit-button{ type: 'submit', value: _('Comment') }
|
||||||
|
|
||||||
- if @note.can_be_discussion_note?
|
- if @note.can_be_discussion_note?
|
||||||
= button_tag type: 'button', class: 'btn btn-nr dropdown-toggle comment-btn js-note-new-discussion js-disable-on-submit', data: { 'dropdown-trigger' => '#resolvable-comment-menu' }, 'aria-label' => _('Open comment type dropdown') do
|
= button_tag type: 'button', class: 'btn btn-nr dropdown-toggle btn-success js-note-new-discussion js-disable-on-submit', data: { 'dropdown-trigger' => '#resolvable-comment-menu' }, 'aria-label' => _('Open comment type dropdown') do
|
||||||
= icon('caret-down', class: 'toggle-icon')
|
= icon('caret-down', class: 'toggle-icon')
|
||||||
|
|
||||||
%ul#resolvable-comment-menu.dropdown-menu.dropdown-open-top{ data: { dropdown: true } }
|
%ul#resolvable-comment-menu.dropdown-menu.dropdown-open-top{ data: { dropdown: true } }
|
||||||
|
|
|
@ -0,0 +1,5 @@
|
||||||
|
---
|
||||||
|
title: Remove unused button classes `btn-create` and `comment-btn`
|
||||||
|
merge_request: 23232
|
||||||
|
author: George Tsiolis
|
||||||
|
type: performance
|
Loading…
Reference in New Issue