kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Rename spec local variable to avoid shadowing

Browse source
This commit is contained in:
Matija Čupić 2017-12-01 15:57:43 +01:00
parent 42d87f9085
commit f6057437dc
No known key found for this signature in database
GPG key ID: 4BAF84FFACD2E5DE
1 changed files with 5 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
spec/controllers/projects/clusters_controller_spec.rb
View file

@ -16,10 +16,7 @@ describe Projects::ClustersController do
context 'when project has one or more clusters' do
let(:project) { create(:project) }
let(:clusters) { create_list(:cluster, 2, :provided_by_gcp, projects: [project]) }
before do
clusters.last.enabled = false
end
let(:inactive_cluster) { create(:cluster, :provided_by_gcp, projects: [project]) }
it 'lists available clusters' do
go
@ -56,16 +53,16 @@ describe Projects::ClustersController do
context 'when only enabled clusters are requested' do
it 'returns only enabled clusters' do
get :index, namespace_id: project.namespace, project_id: project, scope: 'active'
clusters = assigns(:clusters)
expect(clusters.all? { |cluster| cluster.enabled == true }).to eq(true)
view_clusters = assigns(:clusters)
expect(view_clusters.all? { |cluster| cluster.enabled == true }).to eq(true)
end
end
context 'when only disabled clusters are requested' do
it 'returns only disabled clusters' do
get :index, namespace_id: project.namespace, project_id: project, scope: 'inactive'
clusters = assigns(:clusters)
expect(clusters.all? { |cluster| cluster.enabled == false }).to eq(true)
view_clusters = assigns(:clusters)
expect(view_clusters.all? { |cluster| cluster.enabled == false }).to eq(true)
end
end
end