From f63850d9d6c3a81e78c93995c904ed6c0785ef19 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Fri, 5 Aug 2022 12:08:59 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../lint/missing_cop_enable_directive.yml | 33 ++++++-- .../components/submit_dropdown.vue | 4 +- .../components/details/package_title.vue | 49 ++++++------ .../container_expiration_policy.vue | 2 +- .../components/expiration_dropdown.vue | 30 ++++--- .../components/packages_cleanup_policy.vue | 2 +- .../packages_cleanup_policy_form.vue | 25 +++--- .../settings/project/constants.js | 2 +- .../shared/components/settings_block.vue | 6 +- .../ci/runners_registration_token/reset.rb | 5 +- app/models/ci/runner.rb | 13 ++- .../process_runner_version_update_service.rb | 27 +++++++ .../reset_registration_token_service.rb | 10 ++- app/views/profiles/emails/index.html.haml | 41 +++++----- app/workers/all_queues.yml | 9 +++ .../process_runner_version_update_worker.rb | 25 ++++++ config/sidekiq_queues.yml | 2 + doc/ci/variables/predefined_variables.md | 2 +- .../project/pages/pages_access_control.md | 2 - .../migrate_shared_vulnerability_scanners.rb | 2 + .../templates/Getting-Started.gitlab-ci.yml | 1 + lib/gitlab/tracking.rb | 2 +- .../tracking/destinations/snowplow_micro.rb | 2 +- .../merge_requests_controller_spec.rb | 7 +- .../settings/registry_settings_spec.rb | 4 - .../__snapshots__/package_title_spec.js.snap | 29 ++++--- ...tainer_expiration_policy_form_spec.js.snap | 3 + .../destinations/snowplow_micro_spec.rb | 36 +-------- spec/lib/gitlab/tracking_spec.rb | 35 +++++--- spec/models/ci/runner_spec.rb | 49 +++++++++--- ...cess_runner_version_update_service_spec.rb | 80 +++++++++++++++++++ .../reset_registration_token_service_spec.rb | 13 +-- ...ocess_runner_version_update_worker_spec.rb | 48 +++++++++++ 33 files changed, 421 insertions(+), 179 deletions(-) create mode 100644 app/services/ci/runners/process_runner_version_update_service.rb create mode 100644 app/workers/ci/runners/process_runner_version_update_worker.rb create mode 100644 spec/services/ci/runners/process_runner_version_update_service_spec.rb create mode 100644 spec/workers/ci/runners/process_runner_version_update_worker_spec.rb diff --git a/.rubocop_todo/lint/missing_cop_enable_directive.yml b/.rubocop_todo/lint/missing_cop_enable_directive.yml index 4c1c8430204..87ac47deaf5 100644 --- a/.rubocop_todo/lint/missing_cop_enable_directive.yml +++ b/.rubocop_todo/lint/missing_cop_enable_directive.yml @@ -1,8 +1,5 @@ --- Lint/MissingCopEnableDirective: - # Offense count: 199 - # Temporarily disabled due to too many offenses - Enabled: false Exclude: - 'app/controllers/admin/users_controller.rb' - 'app/controllers/projects/forks_controller.rb' @@ -20,14 +17,19 @@ Lint/MissingCopEnableDirective: - 'app/graphql/types/ci/build_need_type.rb' - 'app/graphql/types/ci/config/config_type.rb' - 'app/graphql/types/ci/config/group_type.rb' + - 'app/graphql/types/ci/config/include_type.rb' - 'app/graphql/types/ci/config/job_restriction_type.rb' - 'app/graphql/types/ci/config/job_type.rb' - 'app/graphql/types/ci/config/need_type.rb' - 'app/graphql/types/ci/config/stage_type.rb' - 'app/graphql/types/ci/group_type.rb' + - 'app/graphql/types/ci/group_variable_type.rb' + - 'app/graphql/types/ci/instance_variable_type.rb' - 'app/graphql/types/ci/job_artifact_type.rb' - 'app/graphql/types/ci/job_type.rb' + - 'app/graphql/types/ci/manual_variable_type.rb' - 'app/graphql/types/ci/pipeline_message_type.rb' + - 'app/graphql/types/ci/project_variable_type.rb' - 'app/graphql/types/ci/runner_architecture_type.rb' - 'app/graphql/types/ci/runner_platform_type.rb' - 'app/graphql/types/ci/runner_setup_type.rb' @@ -41,6 +43,7 @@ Lint/MissingCopEnableDirective: - 'app/graphql/types/countable_connection_type.rb' - 'app/graphql/types/design_management_type.rb' - 'app/graphql/types/issue_connection_type.rb' + - 'app/graphql/types/limited_countable_connection_type.rb' - 'app/graphql/types/merge_request_connection_type.rb' - 'app/graphql/types/packages/composer/json_type.rb' - 'app/graphql/types/packages/helm/dependency_type.rb' @@ -71,6 +74,7 @@ Lint/MissingCopEnableDirective: - 'db/migrate/20210818061156_remove_project_profile_compound_index_from_dast_profile_schedules.rb' - 'db/migrate/20210818115613_add_index_project_id_on_dast_profile_schedule.rb' - 'db/migrate/20211013014228_add_content_validation_endpoint_to_application_settings.rb' + - 'db/migrate/20220531024905_add_operations_access_levels_to_project_feature.rb' - 'db/post_migrate/20210825182303_remove_duplicate_dast_site_tokens_with_same_token.rb' - 'ee/app/controllers/ee/admin/dashboard_controller.rb' - 'ee/app/controllers/ee/admin/groups_controller.rb' @@ -90,6 +94,7 @@ Lint/MissingCopEnableDirective: - 'ee/app/graphql/types/ci/minutes/project_monthly_usage_type.rb' - 'ee/app/graphql/types/compliance_management/compliance_framework_type.rb' - 'ee/app/graphql/types/dast/profile_cadence_type.rb' + - 'ee/app/graphql/types/geo/ci_secure_file_registry_type.rb' - 'ee/app/graphql/types/geo/group_wiki_repository_registry_type.rb' - 'ee/app/graphql/types/geo/job_artifact_registry_type.rb' - 'ee/app/graphql/types/geo/lfs_object_registry_type.rb' @@ -107,6 +112,7 @@ Lint/MissingCopEnableDirective: - 'ee/app/graphql/types/security_report_summary_type.rb' - 'ee/app/graphql/types/security_scanners.rb' - 'ee/app/graphql/types/time_report_stats_type.rb' + - 'ee/app/graphql/types/timebox_error_type.rb' - 'ee/app/graphql/types/timebox_metrics_type.rb' - 'ee/app/graphql/types/timebox_report_type.rb' - 'ee/app/graphql/types/vulnerabilities_count_by_day_type.rb' @@ -135,20 +141,29 @@ Lint/MissingCopEnableDirective: - 'ee/app/graphql/types/vulnerable_dependency_type.rb' - 'ee/app/graphql/types/vulnerable_kubernetes_resource_type.rb' - 'ee/app/graphql/types/vulnerable_package_type.rb' + - 'ee/app/services/ee/ci/queue/build_queue_service.rb' + - 'ee/app/workers/ci/runners/stale_group_runners_prune_cron_worker.rb' - 'ee/app/workers/groups/export_memberships_worker.rb' - 'ee/app/workers/update_max_seats_used_for_gitlab_com_subscriptions_worker.rb' - 'ee/lib/api/ldap_group_links.rb' - 'ee/lib/api/scim.rb' + - 'ee/lib/ee/gitlab/background_migration/backfill_project_statistics_container_repository_size.rb' - 'ee/lib/ee/gitlab/background_migration/migrate_approver_to_approval_rules.rb' + - 'ee/lib/ee/gitlab/background_migration/purge_stale_security_scans.rb' - 'ee/lib/ee/gitlab/usage_data.rb' - - 'ee/lib/elastic/latest/git_class_proxy.rb' - 'ee/lib/gitlab/spdx/license.rb' + - 'ee/spec/controllers/projects/legacy_pipelines_controller_spec.rb' + - 'ee/spec/helpers/groups/security_features_helper_spec.rb' + - 'ee/spec/helpers/projects/security/discover_helper_spec.rb' + - 'ee/spec/lib/ee/gitlab/background_migration/delete_invalid_epic_issues_spec.rb' + - 'lib/gitlab/audit/null_author.rb' - 'lib/gitlab/auth/ldap/dn.rb' + - 'lib/gitlab/background_migration/backfill_imported_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_issue_search_data.rb' - 'lib/gitlab/background_migration/backfill_iteration_cadence_id_for_boards.rb' - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_children.rb' - 'lib/gitlab/background_migration/backfill_namespace_traversal_ids_roots.rb' - - 'lib/gitlab/background_migration/copy_ci_builds_columns_to_security_scans.rb' + - 'lib/gitlab/background_migration/delete_invalid_epic_issues.rb' - 'lib/gitlab/background_migration/drop_invalid_vulnerabilities.rb' - 'lib/gitlab/background_migration/fix_incorrect_max_seats_used.rb' - 'lib/gitlab/background_migration/mailers/unconfirm_mailer.rb' @@ -161,11 +176,13 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/background_migration/populate_resolved_on_default_branch_column.rb' - 'lib/gitlab/background_migration/populate_test_reports_issue_id.rb' - 'lib/gitlab/background_migration/populate_uuids_for_security_findings.rb' + - 'lib/gitlab/background_migration/purge_stale_security_scans.rb' - 'lib/gitlab/background_migration/recalculate_vulnerabilities_occurrences_uuid.rb' - 'lib/gitlab/background_migration/recalculate_vulnerability_finding_signatures_for_findings.rb' - 'lib/gitlab/background_migration/remove_duplicate_vulnerabilities_findings.rb' - 'lib/gitlab/background_migration/update_jira_tracker_data_deployment_type_based_on_url.rb' - 'lib/gitlab/background_migration/update_users_where_two_factor_auth_required_from_group.rb' + - 'lib/gitlab/buffered_io.rb' - 'lib/gitlab/ci/reports/test_suite_summary.rb' - 'lib/gitlab/data_builder/push.rb' - 'lib/gitlab/database/load_balancing/connection_proxy.rb' @@ -174,7 +191,6 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/github_import/client.rb' - 'lib/gitlab/github_import/importer/diff_note_importer.rb' - 'lib/gitlab/gon_helper.rb' - - 'lib/gitlab/graphql/pagination/keyset/generic_keyset_pagination.rb' - 'lib/gitlab/graphql/pagination/keyset/last_items.rb' - 'lib/gitlab/graphql/standard_graphql_error.rb' - 'lib/gitlab/metrics/methods.rb' @@ -184,10 +200,13 @@ Lint/MissingCopEnableDirective: - 'lib/gitlab/testing/request_blocker_middleware.rb' - 'lib/gitlab/testing/request_inspector_middleware.rb' - 'lib/gitlab/testing/robots_blocker_middleware.rb' + - 'lib/unnested_in_filters/dsl.rb' + - 'lib/unnested_in_filters/rewriter.rb' - 'qa/qa/scenario/test/integration/registry_with_cdn.rb' - 'spec/benchmarks/banzai_benchmark.rb' - 'spec/lib/gitlab/sidekiq_middleware/size_limiter/server_spec.rb' + - 'spec/lib/initializer_connections_spec.rb' - 'spec/support/capybara.rb' - 'spec/support/cycle_analytics_helpers/test_generation.rb' - 'spec/support/google_api/cloud_platform_helpers.rb' - - 'tooling/danger/product_intelligence.rb' \ No newline at end of file + - 'tooling/danger/product_intelligence.rb' diff --git a/app/assets/javascripts/batch_comments/components/submit_dropdown.vue b/app/assets/javascripts/batch_comments/components/submit_dropdown.vue index 7ed77426a5e..54b9953270b 100644 --- a/app/assets/javascripts/batch_comments/components/submit_dropdown.vue +++ b/app/assets/javascripts/batch_comments/components/submit_dropdown.vue @@ -84,7 +84,7 @@ export default { class="submit-review-dropdown" data-qa-selector="submit_review_dropdown" variant="info" - category="secondary" + category="primary" >