kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Merge branch 'danger-throughputs' into 'master'

Browse source 
Danger asks for throughput labels

See merge request gitlab-org/gitlab-ce!30622
This commit is contained in:
Lin Jen-Shin 2019-07-17 15:09:49 +00:00
commit f6399f1dfe
1 changed files with 12 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

12
danger/metadata/Dangerfile
View file

@ -1,5 +1,13 @@
# rubocop:disable Style/SignalException
THROUGHPUT_LABELS = [
'Community contribution',
'security',
'bug',
'feature',
'backstage'
].freeze
if gitlab.mr_body.size < 5
fail "Please provide a proper merge request description."
end
@ -8,6 +16,10 @@ if gitlab.mr_labels.empty?
fail "Please add labels to this merge request."
end
if (THROUGHPUT_LABELS & gitlab.mr_labels).empty?
warn 'Please add a [throughput label](https://about.gitlab.com/handbook/engineering/management/throughput/#implementation) to this merge request.'
end
unless gitlab.mr_json["assignee"]
warn "This merge request does not have any assignee yet. Setting an assignee clarifies who needs to take action on the merge request at any given time."
end