add a comment to the usage of a anti-pattern query

This commit is contained in:
Alexis Reigel 2018-09-13 13:45:11 +02:00
parent b4e2cc4421
commit f7ef78a7b5
No known key found for this signature in database
GPG Key ID: 55ADA7C7B683B329
1 changed files with 6 additions and 0 deletions

View File

@ -31,6 +31,12 @@ module Ci
scope :active, -> { where(active: true) }
scope :paused, -> { where(active: false) }
scope :online, -> { where('contacted_at > ?', contact_time_deadline) }
# The following query using negation is cheaper than using `contacted_at <= ?`
# because there are less runners online than have been created. The
# resulting query is quickly finding online ones and then uses the regular
# indexed search and rejects the ones that are in the previous set. If we
# did `contacted_at <= ?` the query would effectively have to do a seq
# scan.
scope :offline, -> { where.not(id: online) }
scope :ordered, -> { order(id: :desc) }