Ensure we create the secrets at the right time
In `deploy`, if the previous deployment failed, we delete/cleanup all the objects related to the release, including secrets. The problem is that if we create the root password before that, it will be then recreated during the deploy with a random value! By creatigng the secret just before actually deplying a new release, we ensure that it won't be overriden. Signed-off-by: Rémy Coutable <remy@rymai.me>
This commit is contained in:
parent
ef58a64039
commit
f7f42cf345
|
@ -954,7 +954,6 @@ review:
|
|||
- download_gitlab_chart
|
||||
- ensure_namespace
|
||||
- install_tiller
|
||||
- create_secret
|
||||
- install_external_dns
|
||||
- deploy
|
||||
environment:
|
||||
|
|
|
@ -126,6 +126,9 @@ function deploy() {
|
|||
delete
|
||||
cleanup
|
||||
fi
|
||||
|
||||
create_secret
|
||||
|
||||
helm repo add gitlab https://charts.gitlab.io/
|
||||
helm dep update .
|
||||
|
||||
|
|
Loading…
Reference in New Issue