Refactor gitlab auth tests

spec/lib/gitlab/auth_spec.rb

@@ -4,25 +4,27 @@ describe Gitlab::Auth do
   let(:gl_auth) { Gitlab::Auth.new }
 
   describe :find do
-    before do
+    let!(:user) do
-      @user = create(
+      create(:user,
-        :user,
+        username: username,
-        username: 'john',
+        password: password,
-        password: '88877711',
+        password_confirmation: password)
-        password_confirmation: '88877711'
-      )
     end
+    let(:username) { 'john' }
+    let(:password) { 'my-secret' }
 
     it "should find user by valid login/password" do
-      gl_auth.find('john', '88877711').should == @user
+      expect( gl_auth.find(username, password) ).to eql user
     end
 
     it "should not find user with invalid password" do
-      gl_auth.find('john', 'invalid11').should_not == @user
+      password = 'wrong'
+      expect( gl_auth.find(username, password) ).to_not eql user
     end
 
-    it "should not find user with invalid login and password" do
+    it "should not find user with invalid login" do
-      gl_auth.find('jon', 'invalid11').should_not == @user
+      user = 'wrong'
+      expect( gl_auth.find(username, password) ).to_not eql user
     end
   end
 end