Fix global state in registrations_controller_spec

This spec would mess with global state used for captchas, but not reset
the state in all cases. This would then lead to the spec
spec/controllers/snippets_controller_spec.rb failing, but only on a fork
of gitlab-ee. To fix this we ensure the state is properly reset after
running the specs that change this state.
This commit is contained in:
Yorick Peterse 2019-09-05 18:38:19 +02:00
parent a76643ad24
commit fa5c52217d
No known key found for this signature in database
GPG Key ID: EDD30D2BEB691AC9
1 changed files with 7 additions and 5 deletions

View File

@ -83,6 +83,13 @@ describe RegistrationsController do
stub_application_setting(recaptcha_enabled: true)
end
after do
# Avoid test ordering issue and ensure `verify_recaptcha` returns true
unless Recaptcha.configuration.skip_verify_env.include?('test')
Recaptcha.configuration.skip_verify_env << 'test'
end
end
it 'displays an error when the reCAPTCHA is not solved' do
fail_recaptcha
@ -93,11 +100,6 @@ describe RegistrationsController do
end
it 'redirects to the dashboard when the recaptcha is solved' do
# Avoid test ordering issue and ensure `verify_recaptcha` returns true
unless Recaptcha.configuration.skip_verify_env.include?('test')
Recaptcha.configuration.skip_verify_env << 'test'
end
post(:create, params: user_params)
expect(flash[:notice]).to include 'Welcome! You have signed up successfully.'