From fa6c2426a5beed14dd7cfd0b4c493ff7ec886837 Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Thu, 19 Nov 2020 12:09:26 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- GITALY_SERVER_VERSION | 2 +- .../components/alerts_integrations_list.vue | 4 +- .../components/alerts_settings_form_old.vue | 494 ------------------ .../components/alerts_settings_wrapper.vue | 22 +- .../alerts_settings/services/index.js | 21 - .../sidebar/board_editable_item.vue | 6 +- .../sidebar/board_sidebar_labels_select.vue | 3 +- .../groups/members/components/app.vue | 4 +- .../javascripts/groups/members/index.js | 8 +- .../javascripts/lib/utils/common_utils.js | 45 +- .../access_request_action_buttons.vue | 0 .../action_buttons/action_button_group.vue | 0 .../approve_access_request_button.vue | 0 .../action_buttons/group_action_buttons.vue | 0 .../action_buttons/invite_action_buttons.vue | 0 .../action_buttons/leave_button.vue | 2 +- .../remove_group_link_button.vue | 0 .../action_buttons/remove_member_button.vue | 0 .../action_buttons/resend_invite_button.vue | 0 .../action_buttons/user_action_buttons.vue | 2 +- .../components}/avatars/group_avatar.vue | 2 +- .../components}/avatars/invite_avatar.vue | 2 +- .../components}/avatars/user_avatar.vue | 4 +- .../components}/modals/leave_modal.vue | 2 +- .../modals/remove_group_link_modal.vue | 2 +- .../components}/table/created_at.vue | 0 .../table/expiration_datepicker.vue | 0 .../components}/table/expires_at.vue | 2 +- .../table/member_action_buttons.vue | 2 +- .../components}/table/member_avatar.vue | 0 .../components}/table/member_source.vue | 0 .../components}/table/members_table.vue | 15 +- .../components}/table/members_table_cell.vue | 11 +- .../components}/table/role_dropdown.vue | 3 +- .../components => }/members/constants.js | 0 .../members => members/store}/actions.js | 0 app/assets/javascripts/members/store/index.js | 9 + .../store}/mutation_types.js | 0 .../members => members/store}/mutations.js | 0 .../members => members/store}/state.js | 0 .../members => members/store}/utils.js | 0 .../components => }/members/utils.js | 0 .../notes/mixins/discussion_navigation.js | 9 +- app/assets/javascripts/users_select/index.js | 2 +- .../labels_select_vue/labels_select_root.vue | 10 + .../vuex_shared/modules/members/index.js | 10 - .../settings/operations_controller.rb | 1 - .../metrics_and_profiling.html.haml | 8 +- app/views/admin/runners/show.html.haml | 2 +- .../experience_levels/show.html.haml | 8 +- ...5502-http-integrations-list-ff-removal.yml | 5 + ...ove-Runner-Breadcrumb-in-Admin-Section.yml | 5 + .../defect-jump-to-next-overscroll.yml | 5 + ...-or-experienced-copy-during-onboarding.yml | 6 + ...ce-fa-chevron-dropdown-in-users-select.yml | 5 + ...ntepluhina-fix-swimlanes-on-edit-board.yml | 5 + .../development/http_integrations_list.yml | 8 - doc/api/projects.md | 12 + .../graphql/connection_collection_methods.rb | 13 + lib/gitlab/graphql/connection_redaction.rb | 33 ++ .../graphql/pagination/array_connection.rb | 15 + lib/gitlab/graphql/pagination/connections.rb | 4 + .../externally_paginated_array_connection.rb | 3 + .../graphql/pagination/keyset/connection.rb | 2 + ...ffset_active_record_relation_connection.rb | 2 + locale/gitlab.pot | 47 +- qa/qa/page/group/members.rb | 4 +- spec/features/admin/admin_runners_spec.rb | 6 + .../user_views_alerts_settings_spec.rb | 15 +- .../registrations/experience_level_spec.rb | 8 +- .../alerts_settings_form_old_spec.js.snap | 47 -- .../alerts_integrations_list_spec.js | 3 - .../alerts_settings_form_old_spec.js | 204 -------- .../alerts_settings_wrapper_spec.js | 31 +- .../groups/members/components/app_spec.js | 7 +- spec/frontend/lib/utils/common_utils_spec.js | 1 + .../access_request_action_buttons_spec.js | 8 +- .../approve_access_request_button_spec.js | 2 +- .../invite_action_buttons_spec.js | 8 +- .../action_buttons/leave_button_spec.js | 8 +- .../remove_group_link_button_spec.js | 4 +- .../remove_member_button_spec.js | 2 +- .../resend_invite_button_spec.js | 2 +- .../user_action_buttons_spec.js | 8 +- .../components}/avatars/group_avatar_spec.js | 4 +- .../components}/avatars/invite_avatar_spec.js | 4 +- .../components}/avatars/user_avatar_spec.js | 4 +- .../components}/modals/leave_modal_spec.js | 6 +- .../modals/remove_group_link_modal_spec.js | 6 +- .../components}/table/created_at_spec.js | 2 +- .../table/expiration_datepicker_spec.js | 4 +- .../components}/table/expires_at_spec.js | 2 +- .../table/member_action_buttons_spec.js | 14 +- .../components}/table/member_avatar_spec.js | 12 +- .../components}/table/member_source_spec.js | 2 +- .../table/members_table_cell_spec.js} | 8 +- .../components}/table/members_table_spec.js | 20 +- .../components}/table/role_dropdown_spec.js | 4 +- .../components => }/members/mock_data.js | 0 .../members => members/store}/actions_spec.js | 6 +- .../store}/mutations_spec.js | 6 +- .../members => members/store}/utils_spec.js | 4 +- .../components => }/members/utils_spec.js | 2 +- .../mixins/discussion_navigation_spec.js | 5 +- .../labels_select_root_spec.js | 104 ++-- .../pagination/array_connection_spec.rb | 15 + ...ernally_paginated_array_connection_spec.rb | 6 + .../pagination/keyset/connection_spec.rb | 7 + ..._active_record_relation_connection_spec.rb | 11 + .../connection_redaction_shared_examples.rb | 54 ++ .../graphql/connection_shared_examples.rb | 9 + 111 files changed, 504 insertions(+), 1072 deletions(-) delete mode 100644 app/assets/javascripts/alerts_settings/components/alerts_settings_form_old.vue rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/access_request_action_buttons.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/action_button_group.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/approve_access_request_button.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/group_action_buttons.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/invite_action_buttons.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/leave_button.vue (93%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/remove_group_link_button.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/remove_member_button.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/resend_invite_button.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/action_buttons/user_action_buttons.vue (94%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/avatars/group_avatar.vue (93%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/avatars/invite_avatar.vue (92%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/avatars/user_avatar.vue (94%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/modals/leave_modal.vue (97%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/modals/remove_group_link_modal.vue (96%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/created_at.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/expiration_datepicker.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/expires_at.vue (96%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/member_action_buttons.vue (96%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/member_avatar.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/member_source.vue (100%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/members_table.vue (92%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/members_table_cell.vue (89%) rename app/assets/javascripts/{vue_shared/components/members => members/components}/table/role_dropdown.vue (95%) rename app/assets/javascripts/{vue_shared/components => }/members/constants.js (100%) rename app/assets/javascripts/{vuex_shared/modules/members => members/store}/actions.js (100%) create mode 100644 app/assets/javascripts/members/store/index.js rename app/assets/javascripts/{vuex_shared/modules/members => members/store}/mutation_types.js (100%) rename app/assets/javascripts/{vuex_shared/modules/members => members/store}/mutations.js (100%) rename app/assets/javascripts/{vuex_shared/modules/members => members/store}/state.js (100%) rename app/assets/javascripts/{vuex_shared/modules/members => members/store}/utils.js (100%) rename app/assets/javascripts/{vue_shared/components => }/members/utils.js (100%) delete mode 100644 app/assets/javascripts/vuex_shared/modules/members/index.js create mode 100644 changelogs/unreleased/255502-http-integrations-list-ff-removal.yml create mode 100644 changelogs/unreleased/257888-Improve-Runner-Breadcrumb-in-Admin-Section.yml create mode 100644 changelogs/unreleased/defect-jump-to-next-overscroll.yml create mode 100644 changelogs/unreleased/dreedy-iterate-on-novice-or-experienced-copy-during-onboarding.yml create mode 100644 changelogs/unreleased/mw-replace-fa-chevron-dropdown-in-users-select.yml create mode 100644 changelogs/unreleased/ntepluhina-fix-swimlanes-on-edit-board.yml delete mode 100644 config/feature_flags/development/http_integrations_list.yml create mode 100644 lib/gitlab/graphql/connection_collection_methods.rb create mode 100644 lib/gitlab/graphql/connection_redaction.rb create mode 100644 lib/gitlab/graphql/pagination/array_connection.rb delete mode 100644 spec/frontend/alerts_settings/__snapshots__/alerts_settings_form_old_spec.js.snap delete mode 100644 spec/frontend/alerts_settings/alerts_settings_form_old_spec.js rename spec/frontend/{vue_shared/components/members => members/components}/action_buttons/access_request_action_buttons_spec.js (86%) rename spec/frontend/{vue_shared/components/members => members/components}/action_buttons/approve_access_request_button_spec.js (93%) rename spec/frontend/{vue_shared/components/members => members/components}/action_buttons/invite_action_buttons_spec.js (84%) rename spec/frontend/{vue_shared/components/members => members/components}/action_buttons/leave_button_spec.js (82%) rename spec/frontend/{vue_shared/components/members => members/components}/action_buttons/remove_group_link_button_spec.js (90%) rename spec/frontend/{vue_shared/components/members => members/components}/action_buttons/remove_member_button_spec.js (94%) rename spec/frontend/{vue_shared/components/members => members/components}/action_buttons/resend_invite_button_spec.js (94%) rename spec/frontend/{vue_shared/components/members => members/components}/action_buttons/user_action_buttons_spec.js (85%) rename spec/frontend/{vue_shared/components/members => members/components}/avatars/group_avatar_spec.js (88%) rename spec/frontend/{vue_shared/components/members => members/components}/avatars/invite_avatar_spec.js (85%) rename spec/frontend/{vue_shared/components/members => members/components}/avatars/user_avatar_spec.js (95%) rename spec/frontend/{vue_shared/components/members => members/components}/modals/leave_modal_spec.js (91%) rename spec/frontend/{vue_shared/components/members => members/components}/modals/remove_group_link_modal_spec.js (92%) rename spec/frontend/{vue_shared/components/members => members/components}/table/created_at_spec.js (95%) rename spec/frontend/{vue_shared/components/members => members/components}/table/expiration_datepicker_spec.js (96%) rename spec/frontend/{vue_shared/components/members => members/components}/table/expires_at_spec.js (97%) rename spec/frontend/{vue_shared/components/members => members/components}/table/member_action_buttons_spec.js (67%) rename spec/frontend/{vue_shared/components/members => members/components}/table/member_avatar_spec.js (72%) rename spec/frontend/{vue_shared/components/members => members/components}/table/member_source_spec.js (95%) rename spec/frontend/{vue_shared/components/members/table/member_table_cell_spec.js => members/components/table/members_table_cell_spec.js} (96%) rename spec/frontend/{vue_shared/components/members => members/components}/table/members_table_spec.js (89%) rename spec/frontend/{vue_shared/components/members => members/components}/table/role_dropdown_spec.js (97%) rename spec/frontend/{vue_shared/components => }/members/mock_data.js (100%) rename spec/frontend/{vuex_shared/modules/members => members/store}/actions_spec.js (95%) rename spec/frontend/{vuex_shared/modules/members => members/store}/mutations_spec.js (93%) rename spec/frontend/{vuex_shared/modules/members => members/store}/utils_spec.js (63%) rename spec/frontend/{vue_shared/components => }/members/utils_spec.js (98%) create mode 100644 spec/lib/gitlab/graphql/pagination/array_connection_spec.rb create mode 100644 spec/support/shared_examples/graphql/connection_redaction_shared_examples.rb create mode 100644 spec/support/shared_examples/graphql/connection_shared_examples.rb diff --git a/GITALY_SERVER_VERSION b/GITALY_SERVER_VERSION index ca6c1ec391c..7ce38a2ddcf 100644 --- a/GITALY_SERVER_VERSION +++ b/GITALY_SERVER_VERSION @@ -1 +1 @@ -3aa577d5e9ad572a22966775126076ec4dce2bfb +d5024702496569b6de051046e5e295c44de94be5 diff --git a/app/assets/javascripts/alerts_settings/components/alerts_integrations_list.vue b/app/assets/javascripts/alerts_settings/components/alerts_integrations_list.vue index 12c0409629f..cf16750dbf8 100644 --- a/app/assets/javascripts/alerts_settings/components/alerts_integrations_list.vue +++ b/app/assets/javascripts/alerts_settings/components/alerts_integrations_list.vue @@ -11,7 +11,6 @@ import { GlSprintf, } from '@gitlab/ui'; import { s__, __ } from '~/locale'; -import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin'; import Tracking from '~/tracking'; import { trackAlertIntegrationsViewsOptions, @@ -54,7 +53,6 @@ export default { GlTooltip: GlTooltipDirective, GlModal: GlModalDirective, }, - mixins: [glFeatureFlagsMixin()], props: { integrations: { type: Array, @@ -170,7 +168,7 @@ export default {