Remove some disabled cops.
This commit is contained in:
parent
ae6edf18fc
commit
fb4f3a473b
363
.rubocop.yml
363
.rubocop.yml
|
@ -37,10 +37,6 @@ AllCops:
|
||||||
Style/AccessModifierIndentation:
|
Style/AccessModifierIndentation:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Check the naming of accessor methods for get_/set_.
|
|
||||||
Style/AccessorMethodName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use alias_method instead of alias.
|
# Use alias_method instead of alias.
|
||||||
Style/Alias:
|
Style/Alias:
|
||||||
EnforcedStyle: prefer_alias_method
|
EnforcedStyle: prefer_alias_method
|
||||||
|
@ -54,14 +50,6 @@ Style/AlignArray:
|
||||||
Style/AlignHash:
|
Style/AlignHash:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Align the parameters of a method call if they span more than one line.
|
|
||||||
Style/AlignParameters:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use &&/|| instead of and/or.
|
|
||||||
Style/AndOr:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use `Array#join` instead of `Array#*`.
|
# Use `Array#join` instead of `Array#*`.
|
||||||
Style/ArrayJoin:
|
Style/ArrayJoin:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -82,10 +70,6 @@ Style/Attr:
|
||||||
Style/BeginBlock:
|
Style/BeginBlock:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks if usage of %() or %Q() matches configuration.
|
|
||||||
Style/BarePercentLiterals:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Do not use block comments.
|
# Do not use block comments.
|
||||||
Style/BlockComments:
|
Style/BlockComments:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -99,14 +83,6 @@ Style/BlockEndNewline:
|
||||||
Style/BlockDelimiters:
|
Style/BlockDelimiters:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Enforce braces style around hash parameters.
|
|
||||||
Style/BracesAroundHashParameters:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Avoid explicit use of the case equality operator(===).
|
|
||||||
Style/CaseEquality:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Indentation of when in a case/when/[else/]end.
|
# Indentation of when in a case/when/[else/]end.
|
||||||
Style/CaseIndentation:
|
Style/CaseIndentation:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -135,24 +111,10 @@ Style/ClassMethods:
|
||||||
Style/ClassVars:
|
Style/ClassVars:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Do not use :: for method call.
|
|
||||||
Style/ColonMethodCall:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks formatting of special comments (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
|
|
||||||
Style/CommentAnnotation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Indentation of comments.
|
# Indentation of comments.
|
||||||
Style/CommentIndentation:
|
Style/CommentIndentation:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Use the return value of `if` and `case` statements for assignment to a
|
|
||||||
# variable and variable comparison instead of assigning that variable
|
|
||||||
# inside of each branch.
|
|
||||||
Style/ConditionalAssignment:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Constants should use SCREAMING_SNAKE_CASE.
|
# Constants should use SCREAMING_SNAKE_CASE.
|
||||||
Style/ConstantName:
|
Style/ConstantName:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -165,26 +127,10 @@ Style/DefWithParentheses:
|
||||||
Style/Documentation:
|
Style/Documentation:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
# Checks the position of the dot in multi-line method calls.
|
|
||||||
Style/DotPosition:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for uses of double negation (!!).
|
|
||||||
Style/DoubleNegation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Prefer `each_with_object` over `inject` or `reduce`.
|
|
||||||
Style/EachWithObject:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Align elses and elsifs correctly.
|
# Align elses and elsifs correctly.
|
||||||
Style/ElseAlignment:
|
Style/ElseAlignment:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Avoid empty else-clauses.
|
|
||||||
Style/EmptyElse:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use empty lines between defs.
|
# Use empty lines between defs.
|
||||||
Style/EmptyLineBetweenDefs:
|
Style/EmptyLineBetweenDefs:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
@ -213,10 +159,6 @@ Style/EmptyLinesAroundModuleBody:
|
||||||
Style/EmptyLinesAroundMethodBody:
|
Style/EmptyLinesAroundMethodBody:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
# Prefer literals to Array.new/Hash.new/String.new.
|
|
||||||
Style/EmptyLiteral:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Avoid the use of END blocks.
|
# Avoid the use of END blocks.
|
||||||
Style/EndBlock:
|
Style/EndBlock:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -229,10 +171,6 @@ Style/EndOfLine:
|
||||||
Style/EvenOdd:
|
Style/EvenOdd:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Do not use unnecessary spacing.
|
|
||||||
Style/ExtraSpacing:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use snake_case for source file names.
|
# Use snake_case for source file names.
|
||||||
Style/FileName:
|
Style/FileName:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -250,31 +188,15 @@ Style/FlipFlop:
|
||||||
Style/For:
|
Style/For:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Enforce the use of Kernel#sprintf, Kernel#format or String#%.
|
|
||||||
Style/FormatString:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Do not introduce global variables.
|
# Do not introduce global variables.
|
||||||
Style/GlobalVars:
|
Style/GlobalVars:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Check for conditionals that can be replaced with guard clauses.
|
|
||||||
Style/GuardClause:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Prefer Ruby 1.9 hash syntax `{ a: 1, b: 2 }`
|
# Prefer Ruby 1.9 hash syntax `{ a: 1, b: 2 }`
|
||||||
# over 1.8 syntax `{ :a => 1, :b => 2 }`.
|
# over 1.8 syntax `{ :a => 1, :b => 2 }`.
|
||||||
Style/HashSyntax:
|
Style/HashSyntax:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Finds if nodes inside else, which can be converted to elsif.
|
|
||||||
Style/IfInsideElse:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Favor modifier if/unless usage when you have a single-line body.
|
|
||||||
Style/IfUnlessModifier:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Do not use if x; .... Use the ternary operator instead.
|
# Do not use if x; .... Use the ternary operator instead.
|
||||||
Style/IfWithSemicolon:
|
Style/IfWithSemicolon:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -297,22 +219,10 @@ Style/IndentationConsistency:
|
||||||
Style/IndentationWidth:
|
Style/IndentationWidth:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks the indentation of the first element in an array literal.
|
|
||||||
Style/IndentArray:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks the indentation of the first key in a hash literal.
|
|
||||||
Style/IndentHash:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use Kernel#loop for infinite loops.
|
# Use Kernel#loop for infinite loops.
|
||||||
Style/InfiniteLoop:
|
Style/InfiniteLoop:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Use the new lambda literal syntax for single-line blocks.
|
|
||||||
Style/Lambda:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use lambda.call(...) instead of lambda.(...).
|
# Use lambda.call(...) instead of lambda.(...).
|
||||||
Style/LambdaCall:
|
Style/LambdaCall:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -321,14 +231,6 @@ Style/LambdaCall:
|
||||||
Style/LeadingCommentSpace:
|
Style/LeadingCommentSpace:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Use \ instead of + or << to concatenate two string literals at line end.
|
|
||||||
Style/LineEndConcatenation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Do not use parentheses for method calls with no arguments.
|
|
||||||
Style/MethodCallParentheses:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks if the method definitions have or don't have parentheses.
|
# Checks if the method definitions have or don't have parentheses.
|
||||||
Style/MethodDefParentheses:
|
Style/MethodDefParentheses:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -337,10 +239,6 @@ Style/MethodDefParentheses:
|
||||||
Style/MethodName:
|
Style/MethodName:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks for usage of `extend self` in modules.
|
|
||||||
Style/ModuleFunction:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks that the closing brace in an array literal is either on the same line
|
# Checks that the closing brace in an array literal is either on the same line
|
||||||
# as the last array element, or a new line.
|
# as the last array element, or a new line.
|
||||||
Style/MultilineArrayBraceLayout:
|
Style/MultilineArrayBraceLayout:
|
||||||
|
@ -385,39 +283,18 @@ Style/MultilineMethodDefinitionBraceLayout:
|
||||||
Style/MultilineOperationIndentation:
|
Style/MultilineOperationIndentation:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
# Avoid multi-line `? :` (the ternary operator), use if/unless instead.
|
|
||||||
Style/MultilineTernaryOperator:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Do not assign mutable objects to constants.
|
|
||||||
Style/MutableConstant:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Favor unless over if for negative conditions (or control flow or).
|
# Favor unless over if for negative conditions (or control flow or).
|
||||||
Style/NegatedIf:
|
Style/NegatedIf:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Favor until over while for negative conditions.
|
|
||||||
Style/NegatedWhile:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Avoid using nested modifiers.
|
# Avoid using nested modifiers.
|
||||||
Style/NestedModifier:
|
Style/NestedModifier:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Parenthesize method calls which are nested inside the argument list of
|
|
||||||
# another parenthesized method call.
|
|
||||||
Style/NestedParenthesizedCalls:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use one expression per branch in a ternary operator.
|
# Use one expression per branch in a ternary operator.
|
||||||
Style/NestedTernaryOperator:
|
Style/NestedTernaryOperator:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Use `next` to skip iteration instead of a condition at the end.
|
|
||||||
Style/Next:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Prefer x.nil? to x == nil.
|
# Prefer x.nil? to x == nil.
|
||||||
Style/NilComparison:
|
Style/NilComparison:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -442,51 +319,10 @@ Style/OneLineConditional:
|
||||||
Style/OpMethod:
|
Style/OpMethod:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Check for simple usages of parallel assignment. It will only warn when
|
|
||||||
# the number of variables matches on both sides of the assignment.
|
|
||||||
Style/ParallelAssignment:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Don't use parentheses around the condition of an if/unless/while.
|
# Don't use parentheses around the condition of an if/unless/while.
|
||||||
Style/ParenthesesAroundCondition:
|
Style/ParenthesesAroundCondition:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Use `%`-literal delimiters consistently.
|
|
||||||
Style/PercentLiteralDelimiters:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks if uses of %Q/%q match the configured preference.
|
|
||||||
Style/PercentQLiterals:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Avoid Perl-style regex back references.
|
|
||||||
Style/PerlBackrefs:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Check the names of predicate methods.
|
|
||||||
Style/PredicateName:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use proc instead of Proc.new.
|
|
||||||
Style/Proc:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks the arguments passed to raise/fail.
|
|
||||||
Style/RaiseArgs:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Don't use begin blocks when they are not needed.
|
|
||||||
Style/RedundantBegin:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for an obsolete RuntimeException argument in raise/fail.
|
|
||||||
Style/RedundantException:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks usages of Object#freeze on immutable objects.
|
|
||||||
Style/RedundantFreeze:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for parentheses that seem not to serve any purpose.
|
# Checks for parentheses that seem not to serve any purpose.
|
||||||
Style/RedundantParentheses:
|
Style/RedundantParentheses:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -495,24 +331,6 @@ Style/RedundantParentheses:
|
||||||
Style/RedundantReturn:
|
Style/RedundantReturn:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Don't use self where it's not needed.
|
|
||||||
Style/RedundantSelf:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use %r for regular expressions matching more than `MaxSlashes` '/'
|
|
||||||
# characters. Use %r only for regular expressions matching more
|
|
||||||
# than `MaxSlashes` '/' character.
|
|
||||||
Style/RegexpLiteral:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Avoid using rescue in its modifier form.
|
|
||||||
Style/RescueModifier:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for places where self-assignment shorthand should have been used.
|
|
||||||
Style/SelfAssignment:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Don't use semicolons to terminate expressions.
|
# Don't use semicolons to terminate expressions.
|
||||||
Style/Semicolon:
|
Style/Semicolon:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -522,14 +340,6 @@ Style/SignalException:
|
||||||
EnforcedStyle: only_raise
|
EnforcedStyle: only_raise
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Enforces the names of some block params.
|
|
||||||
Style/SingleLineBlockParams:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Avoid single-line methods.
|
|
||||||
Style/SingleLineMethods:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use spaces after colons.
|
# Use spaces after colons.
|
||||||
Style/SpaceAfterColon:
|
Style/SpaceAfterColon:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -551,11 +361,6 @@ Style/SpaceAfterNot:
|
||||||
Style/SpaceAfterSemicolon:
|
Style/SpaceAfterSemicolon:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks that the equals signs in parameter default assignments have or don't
|
|
||||||
# have surrounding space depending on configuration.
|
|
||||||
Style/SpaceAroundEqualsInParameterDefault:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use a space around keywords if appropriate.
|
# Use a space around keywords if appropriate.
|
||||||
Style/SpaceAroundKeyword:
|
Style/SpaceAroundKeyword:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -564,10 +369,6 @@ Style/SpaceAroundKeyword:
|
||||||
Style/SpaceAroundOperators:
|
Style/SpaceAroundOperators:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks that the left block brace has or doesn't have space before it.
|
|
||||||
Style/SpaceBeforeBlockBraces:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# No spaces before commas.
|
# No spaces before commas.
|
||||||
Style/SpaceBeforeComma:
|
Style/SpaceBeforeComma:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -576,33 +377,14 @@ Style/SpaceBeforeComma:
|
||||||
Style/SpaceBeforeComment:
|
Style/SpaceBeforeComment:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks that exactly one space is used between a method name and the first
|
|
||||||
# argument for method calls without parentheses.
|
|
||||||
Style/SpaceBeforeFirstArg:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# No spaces before semicolons.
|
# No spaces before semicolons.
|
||||||
Style/SpaceBeforeSemicolon:
|
Style/SpaceBeforeSemicolon:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks that block braces have or don't have surrounding space.
|
|
||||||
# For blocks taking parameters, checks that the left brace has or doesn't
|
|
||||||
# have trailing space.
|
|
||||||
Style/SpaceInsideBlockBraces:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# No spaces after [ or before ].
|
|
||||||
Style/SpaceInsideBrackets:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use spaces inside hash literal braces - or don't.
|
# Use spaces inside hash literal braces - or don't.
|
||||||
Style/SpaceInsideHashLiteralBraces:
|
Style/SpaceInsideHashLiteralBraces:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# No spaces after ( or before ).
|
|
||||||
Style/SpaceInsideParens:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# No spaces inside range literals.
|
# No spaces inside range literals.
|
||||||
Style/SpaceInsideRangeLiteral:
|
Style/SpaceInsideRangeLiteral:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -612,10 +394,6 @@ Style/SpaceInsideStringInterpolation:
|
||||||
EnforcedStyle: no_space
|
EnforcedStyle: no_space
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Avoid Perl-style global variables.
|
|
||||||
Style/SpecialGlobalVars:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Check for the usage of parentheses around stabby lambda arguments.
|
# Check for the usage of parentheses around stabby lambda arguments.
|
||||||
Style/StabbyLambdaParentheses:
|
Style/StabbyLambdaParentheses:
|
||||||
EnforcedStyle: require_parentheses
|
EnforcedStyle: require_parentheses
|
||||||
|
@ -625,25 +403,12 @@ Style/StabbyLambdaParentheses:
|
||||||
Style/StringLiterals:
|
Style/StringLiterals:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
# Checks if uses of quotes inside expressions in interpolated strings match the
|
|
||||||
# configured preference.
|
|
||||||
Style/StringLiteralsInInterpolation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks if configured preferred methods are used over non-preferred.
|
# Checks if configured preferred methods are used over non-preferred.
|
||||||
Style/StringMethods:
|
Style/StringMethods:
|
||||||
PreferredMethods:
|
PreferredMethods:
|
||||||
intern: to_sym
|
intern: to_sym
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Use %i or %I for arrays of symbols.
|
|
||||||
Style/SymbolArray:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use symbols as procs instead of blocks when possible.
|
|
||||||
Style/SymbolProc:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# No hard tabs.
|
# No hard tabs.
|
||||||
Style/Tab:
|
Style/Tab:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -652,40 +417,10 @@ Style/Tab:
|
||||||
Style/TrailingBlankLines:
|
Style/TrailingBlankLines:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks for trailing comma in array and hash literals.
|
|
||||||
Style/TrailingCommaInLiteral:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for trailing comma in argument lists.
|
|
||||||
Style/TrailingCommaInArguments:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Avoid trailing whitespace.
|
|
||||||
Style/TrailingWhitespace:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for the usage of unneeded trailing underscores at the end of
|
|
||||||
# parallel variable assignment.
|
|
||||||
Style/TrailingUnderscoreVariable:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Prefer attr_* methods to trivial readers/writers.
|
|
||||||
Style/TrivialAccessors:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Do not use unless with else. Rewrite these with the positive case first.
|
|
||||||
Style/UnlessElse:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for %W when interpolation is not needed.
|
# Checks for %W when interpolation is not needed.
|
||||||
Style/UnneededCapitalW:
|
Style/UnneededCapitalW:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# TODO: Enable UnneededInterpolation Cop.
|
|
||||||
# Checks for strings that are just an interpolated expression.
|
|
||||||
Style/UnneededInterpolation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for %q/%Q when single quotes or double quotes would do.
|
# Checks for %q/%Q when single quotes or double quotes would do.
|
||||||
Style/UnneededPercentQ:
|
Style/UnneededPercentQ:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
@ -715,12 +450,6 @@ Style/WhileUntilModifier:
|
||||||
Style/WordArray:
|
Style/WordArray:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
# TODO: Enable ZeroLengthPredicate Cop.
|
|
||||||
# Use #empty? when testing for objects of length 0.
|
|
||||||
Style/ZeroLengthPredicate:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
|
|
||||||
#################### Metrics ################################
|
#################### Metrics ################################
|
||||||
|
|
||||||
# A calculated magnitude based on number of assignments,
|
# A calculated magnitude based on number of assignments,
|
||||||
|
@ -774,15 +503,6 @@ Metrics/PerceivedComplexity:
|
||||||
Lint/AmbiguousOperator:
|
Lint/AmbiguousOperator:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks for ambiguous regexp literals in the first argument of a method
|
|
||||||
# invocation without parentheses.
|
|
||||||
Lint/AmbiguousRegexpLiteral:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Don't use assignment in conditions.
|
|
||||||
Lint/AssignmentInCondition:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Align block ends correctly.
|
# Align block ends correctly.
|
||||||
Lint/BlockAlignment:
|
Lint/BlockAlignment:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -808,14 +528,6 @@ Lint/DefEndAlignment:
|
||||||
Lint/DeprecatedClassMethods:
|
Lint/DeprecatedClassMethods:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Check for duplicate method definitions.
|
|
||||||
Lint/DuplicateMethods:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Check for duplicate keys in hash literals.
|
|
||||||
Lint/DuplicatedKey:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Check for immutable argument given to each_with_object.
|
# Check for immutable argument given to each_with_object.
|
||||||
Lint/EachWithObjectArgument:
|
Lint/EachWithObjectArgument:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -828,10 +540,6 @@ Lint/ElseLayout:
|
||||||
Lint/EmptyEnsure:
|
Lint/EmptyEnsure:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks for empty string interpolation.
|
|
||||||
Lint/EmptyInterpolation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Align ends correctly.
|
# Align ends correctly.
|
||||||
Lint/EndAlignment:
|
Lint/EndAlignment:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -856,21 +564,11 @@ Lint/FloatOutOfRange:
|
||||||
Lint/FormatParameterMismatch:
|
Lint/FormatParameterMismatch:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Don't suppress exception.
|
|
||||||
Lint/HandleExceptions:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for adjacent string literals on the same line, which could better be
|
# Checks for adjacent string literals on the same line, which could better be
|
||||||
# represented as a single string literal.
|
# represented as a single string literal.
|
||||||
Lint/ImplicitStringConcatenation:
|
Lint/ImplicitStringConcatenation:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# TODO: Enable IneffectiveAccessModifier Cop.
|
|
||||||
# Checks for attempts to use `private` or `protected` to set the visibility
|
|
||||||
# of a class method, which does not work.
|
|
||||||
Lint/IneffectiveAccessModifier:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for invalid character literals with a non-escaped whitespace
|
# Checks for invalid character literals with a non-escaped whitespace
|
||||||
# character.
|
# character.
|
||||||
Lint/InvalidCharacterLiteral:
|
Lint/InvalidCharacterLiteral:
|
||||||
|
@ -884,11 +582,6 @@ Lint/LiteralInCondition:
|
||||||
Lint/LiteralInInterpolation:
|
Lint/LiteralInInterpolation:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Use Kernel#loop with break rather than begin/end/until or begin/end/while
|
|
||||||
# for post-loop tests.
|
|
||||||
Lint/Loop:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Do not use nested method definitions.
|
# Do not use nested method definitions.
|
||||||
Lint/NestedMethodDefinition:
|
Lint/NestedMethodDefinition:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -914,13 +607,8 @@ Lint/RequireParentheses:
|
||||||
Lint/RescueException:
|
Lint/RescueException:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Do not use the same name as outer local variable for block arguments
|
# Checks for the order which exceptions are rescued to avoid rescueing a less specific exception before a more specific exception.
|
||||||
# or block local variables.
|
Lint/ShadowedException:
|
||||||
Lint/ShadowingOuterLocalVariable:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# 'Checks for Object#to_s usage in string interpolation.
|
|
||||||
Lint/StringConversionInInterpolation:
|
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
# Do not use prefix `_` for a variable that is used.
|
# Do not use prefix `_` for a variable that is used.
|
||||||
|
@ -933,22 +621,10 @@ Lint/UnderscorePrefixedVariableName:
|
||||||
Lint/UnneededDisable:
|
Lint/UnneededDisable:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
# Checks for unused block arguments.
|
|
||||||
Lint/UnusedBlockArgument:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for unused method arguments.
|
|
||||||
Lint/UnusedMethodArgument:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Unreachable code.
|
# Unreachable code.
|
||||||
Lint/UnreachableCode:
|
Lint/UnreachableCode:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks for useless access modifiers.
|
|
||||||
Lint/UselessAccessModifier:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Checks for useless assignment to a local variable.
|
# Checks for useless assignment to a local variable.
|
||||||
Lint/UselessAssignment:
|
Lint/UselessAssignment:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -981,11 +657,6 @@ Performance/Casecmp:
|
||||||
Performance/DoubleStartEndWith:
|
Performance/DoubleStartEndWith:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# TODO: Enable EndWith Cop.
|
|
||||||
# Use `end_with?` instead of a regex match anchored to the end of a string.
|
|
||||||
Performance/EndWith:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use `strip` instead of `lstrip.rstrip`.
|
# Use `strip` instead of `lstrip.rstrip`.
|
||||||
Performance/LstripRstrip:
|
Performance/LstripRstrip:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -994,24 +665,6 @@ Performance/LstripRstrip:
|
||||||
Performance/RangeInclude:
|
Performance/RangeInclude:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# TODO: Enable RedundantBlockCall Cop.
|
|
||||||
# Use `yield` instead of `block.call`.
|
|
||||||
Performance/RedundantBlockCall:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# TODO: Enable RedundantMatch Cop.
|
|
||||||
# Use `=~` instead of `String#match` or `Regexp#match` in a context where the
|
|
||||||
# returned `MatchData` is not needed.
|
|
||||||
Performance/RedundantMatch:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# TODO: Enable RedundantMerge Cop.
|
|
||||||
# Use `Hash#[]=`, rather than `Hash#merge!` with a single key-value pair.
|
|
||||||
Performance/RedundantMerge:
|
|
||||||
# Max number of key-value pairs to consider an offense
|
|
||||||
MaxKeyValuePairs: 2
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use `sort` instead of `sort_by { |x| x }`.
|
# Use `sort` instead of `sort_by { |x| x }`.
|
||||||
Performance/RedundantSortBy:
|
Performance/RedundantSortBy:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
@ -1080,18 +733,6 @@ Rails/ReadWriteAttribute:
|
||||||
Rails/ScopeArgs:
|
Rails/ScopeArgs:
|
||||||
Enabled: true
|
Enabled: true
|
||||||
|
|
||||||
# Checks the correct usage of time zone aware methods.
|
|
||||||
# http://danilenko.org/2012/7/6/rails_timezones
|
|
||||||
Rails/TimeZone:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
# Use validates :attribute, hash of validations.
|
|
||||||
Rails/Validation:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
Rails/UniqBeforePluck:
|
|
||||||
Enabled: false
|
|
||||||
|
|
||||||
##################### RSpec ##################################
|
##################### RSpec ##################################
|
||||||
|
|
||||||
# Check that instances are not being stubbed globally.
|
# Check that instances are not being stubbed globally.
|
||||||
|
|
|
@ -1,15 +1,66 @@
|
||||||
# This configuration was generated by
|
# This configuration was generated by
|
||||||
# `rubocop --auto-gen-config`
|
# `rubocop --auto-gen-config --exclude-limit 8`
|
||||||
# on 2016-06-29 18:24:55 +0200 using RuboCop version 0.41.1.
|
# on 2016-07-03 15:32:25 -0600 using RuboCop version 0.41.1.
|
||||||
# The point is for the user to remove these configuration records
|
# The point is for the user to remove these configuration records
|
||||||
# one by one as the offenses are removed from the code base.
|
# one by one as the offenses are removed from the code base.
|
||||||
# Note that changes in the inspected code, or installation of new
|
# Note that changes in the inspected code, or installation of new
|
||||||
# versions of RuboCop, may require this file to be generated again.
|
# versions of RuboCop, may require this file to be generated again.
|
||||||
|
|
||||||
|
# Offense count: 152
|
||||||
|
Lint/AmbiguousRegexpLiteral:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 42
|
||||||
|
# Configuration parameters: AllowSafeAssignment.
|
||||||
|
Lint/AssignmentInCondition:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
# Offense count: 1
|
# Offense count: 1
|
||||||
Lint/ShadowedException:
|
Lint/DuplicateMethods:
|
||||||
Exclude:
|
Exclude:
|
||||||
- 'app/models/u2f_registration.rb'
|
- 'lib/gitlab/github_import/branch_formatter.rb'
|
||||||
|
|
||||||
|
# Offense count: 14
|
||||||
|
Lint/HandleExceptions:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 20
|
||||||
|
Lint/IneffectiveAccessModifier:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 2
|
||||||
|
Lint/Loop:
|
||||||
|
Exclude:
|
||||||
|
- 'app/mailers/notify.rb'
|
||||||
|
- 'lib/gitlab/bitbucket_import/client.rb'
|
||||||
|
|
||||||
|
# Offense count: 12
|
||||||
|
Lint/ShadowingOuterLocalVariable:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 3
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Lint/StringConversionInInterpolation:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/commit_range.rb'
|
||||||
|
- 'app/services/system_hooks_service.rb'
|
||||||
|
- 'app/services/system_note_service.rb'
|
||||||
|
|
||||||
|
# Offense count: 42
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
|
||||||
|
Lint/UnusedBlockArgument:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 125
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
|
||||||
|
Lint/UnusedMethodArgument:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 11
|
||||||
|
Lint/UselessAccessModifier:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
# Offense count: 12
|
# Offense count: 12
|
||||||
# Cop supports --auto-correct.
|
# Cop supports --auto-correct.
|
||||||
|
@ -23,10 +74,263 @@ Performance/PushSplat:
|
||||||
- 'app/models/user.rb'
|
- 'app/models/user.rb'
|
||||||
- 'config/application.rb'
|
- 'config/application.rb'
|
||||||
|
|
||||||
|
# Offense count: 2
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Performance/RedundantBlockCall:
|
||||||
|
Exclude:
|
||||||
|
- 'app/controllers/application_controller.rb'
|
||||||
|
- 'lib/gitlab/backend/shell.rb'
|
||||||
|
|
||||||
|
# Offense count: 5
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Performance/RedundantMatch:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/external_issue.rb'
|
||||||
|
- 'lib/extracts_path.rb'
|
||||||
|
- 'lib/gitlab/diff/highlight.rb'
|
||||||
|
- 'lib/gitlab/diff/inline_diff.rb'
|
||||||
|
- 'lib/gitlab/diff/parser.rb'
|
||||||
|
|
||||||
|
# Offense count: 24
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: MaxKeyValuePairs.
|
||||||
|
Performance/RedundantMerge:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
# Offense count: 59
|
# Offense count: 59
|
||||||
Rails/OutputSafety:
|
Rails/OutputSafety:
|
||||||
Enabled: false
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 125
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: strict, flexible
|
||||||
|
Rails/TimeZone:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 12
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: Include.
|
||||||
|
# Include: app/models/**/*.rb
|
||||||
|
Rails/Validation:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 18
|
||||||
|
Style/AccessorMethodName:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 208
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
||||||
|
# SupportedStyles: with_first_parameter, with_fixed_indentation
|
||||||
|
Style/AlignParameters:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 32
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: always, conditionals
|
||||||
|
Style/AndOr:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 47
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: percent_q, bare_percent
|
||||||
|
Style/BarePercentLiterals:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 255
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: braces, no_braces, context_dependent
|
||||||
|
Style/BracesAroundHashParameters:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 4
|
||||||
|
Style/CaseEquality:
|
||||||
|
Exclude:
|
||||||
|
- 'app/helpers/auth_helper.rb'
|
||||||
|
- 'app/models/commit.rb'
|
||||||
|
- 'app/services/projects/download_service.rb'
|
||||||
|
- 'config/initializers/trusted_proxies.rb'
|
||||||
|
|
||||||
|
# Offense count: 19
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/ColonMethodCall:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 3
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: Keywords.
|
||||||
|
# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
|
||||||
|
Style/CommentAnnotation:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/project.rb'
|
||||||
|
- 'lib/api/entities.rb'
|
||||||
|
- 'spec/requests/api/project_snippets_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 35
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles, SingleLineConditionsOnly.
|
||||||
|
# SupportedStyles: assign_to_condition, assign_inside_condition
|
||||||
|
Style/ConditionalAssignment:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 762
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: leading, trailing
|
||||||
|
Style/DotPosition:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 14
|
||||||
|
Style/DoubleNegation:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 3
|
||||||
|
Style/EachWithObject:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/commit_status.rb'
|
||||||
|
- 'lib/ci/ansi2html.rb'
|
||||||
|
- 'lib/gitlab/import_export/members_mapper.rb'
|
||||||
|
|
||||||
|
# Offense count: 29
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: empty, nil, both
|
||||||
|
Style/EmptyElse:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 3
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/EmptyLiteral:
|
||||||
|
Exclude:
|
||||||
|
- 'features/steps/project/commits/commits.rb'
|
||||||
|
- 'lib/gitlab/fogbugz_import/importer.rb'
|
||||||
|
- 'spec/lib/gitlab/workhorse_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 119
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
|
||||||
|
Style/ExtraSpacing:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 7
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: format, sprintf, percent
|
||||||
|
Style/FormatString:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/ci/pipeline.rb'
|
||||||
|
- 'app/services/gravatar_service.rb'
|
||||||
|
- 'config/initializers/rack_lineprof.rb'
|
||||||
|
- 'lib/ci/version_info.rb'
|
||||||
|
- 'lib/gitlab/version_info.rb'
|
||||||
|
- 'spec/requests/api/issues_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 50
|
||||||
|
# Configuration parameters: MinBodyLength.
|
||||||
|
Style/GuardClause:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 9
|
||||||
|
Style/IdenticalConditionalBranches:
|
||||||
|
Exclude:
|
||||||
|
- 'app/controllers/projects_controller.rb'
|
||||||
|
- 'app/models/project_services/irker_service.rb'
|
||||||
|
- 'app/services/merge_requests/refresh_service.rb'
|
||||||
|
- 'lib/rouge/formatters/html_gitlab.rb'
|
||||||
|
|
||||||
|
# Offense count: 10
|
||||||
|
Style/IfInsideElse:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 178
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: MaxLineLength.
|
||||||
|
Style/IfUnlessModifier:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 48
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
||||||
|
# SupportedStyles: special_inside_parentheses, consistent, align_brackets
|
||||||
|
Style/IndentArray:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 85
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
|
||||||
|
# SupportedStyles: special_inside_parentheses, consistent, align_braces
|
||||||
|
Style/IndentHash:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 11
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: line_count_dependent, lambda, literal
|
||||||
|
Style/Lambda:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/ci/runner.rb'
|
||||||
|
- 'app/models/event.rb'
|
||||||
|
- 'app/models/note.rb'
|
||||||
|
- 'config/routes.rb'
|
||||||
|
- 'lib/api/entities.rb'
|
||||||
|
- 'spec/models/concerns/participable_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 6
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/LineEndConcatenation:
|
||||||
|
Exclude:
|
||||||
|
- 'app/helpers/preferences_helper.rb'
|
||||||
|
- 'app/helpers/tree_helper.rb'
|
||||||
|
- 'app/models/merge_request.rb'
|
||||||
|
- 'app/models/user.rb'
|
||||||
|
- 'spec/lib/gitlab/gfm/reference_rewriter_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 13
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/MethodCallParentheses:
|
||||||
|
Exclude:
|
||||||
|
- 'lib/api/helpers.rb'
|
||||||
|
- 'lib/ci/ansi2html.rb'
|
||||||
|
- 'spec/features/dashboard/datetime_on_tooltips_spec.rb'
|
||||||
|
- 'spec/helpers/submodule_helper_spec.rb'
|
||||||
|
- 'spec/workers/post_receive_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 9
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: module_function, extend_self
|
||||||
|
Style/ModuleFunction:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 3
|
||||||
|
Style/MultilineTernaryOperator:
|
||||||
|
Exclude:
|
||||||
|
- 'lib/banzai/filter/relative_link_filter.rb'
|
||||||
|
- 'spec/support/api_helpers.rb'
|
||||||
|
|
||||||
|
# Offense count: 62
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/MutableConstant:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 10
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/NestedParenthesizedCalls:
|
||||||
|
Exclude:
|
||||||
|
- 'app/helpers/commits_helper.rb'
|
||||||
|
- 'app/workers/irker_worker.rb'
|
||||||
|
- 'spec/lib/gitlab/ci/build/artifacts/metadata/entry_spec.rb'
|
||||||
|
- 'spec/lib/gitlab/email/message/repository_push_spec.rb'
|
||||||
|
- 'spec/services/ci/create_builds_service_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 13
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
|
||||||
|
# SupportedStyles: skip_modifier_ifs, always
|
||||||
|
Style/Next:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
# Offense count: 6
|
# Offense count: 6
|
||||||
# Cop supports --auto-correct.
|
# Cop supports --auto-correct.
|
||||||
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
|
# Configuration parameters: EnforcedOctalStyle, SupportedOctalStyles.
|
||||||
|
@ -39,23 +343,166 @@ Style/NumericLiteralPrefix:
|
||||||
- 'spec/support/test_env.rb'
|
- 'spec/support/test_env.rb'
|
||||||
- 'spec/tasks/gitlab/backup_rake_spec.rb'
|
- 'spec/tasks/gitlab/backup_rake_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 29
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/ParallelAssignment:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 201
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: PreferredDelimiters.
|
||||||
|
Style/PercentLiteralDelimiters:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 11
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: lower_case_q, upper_case_q
|
||||||
|
Style/PercentQLiterals:
|
||||||
|
Exclude:
|
||||||
|
- 'spec/helpers/gitlab_markdown_helper_spec.rb'
|
||||||
|
- 'spec/lib/gitlab/diff/highlight_spec.rb'
|
||||||
|
- 'spec/models/project_services/bamboo_service_spec.rb'
|
||||||
|
- 'spec/models/project_services/teamcity_service_spec.rb'
|
||||||
|
- 'spec/workers/repository_import_worker_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 14
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/PerlBackrefs:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 30
|
||||||
|
# Configuration parameters: NamePrefix, NamePrefixBlacklist, NameWhitelist.
|
||||||
|
# NamePrefix: is_, has_, have_
|
||||||
|
# NamePrefixBlacklist: is_, has_, have_
|
||||||
|
# NameWhitelist: is_a?
|
||||||
|
Style/PredicateName:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
# Offense count: 28
|
# Offense count: 28
|
||||||
# Cop supports --auto-correct.
|
# Cop supports --auto-correct.
|
||||||
Style/PreferredHashMethods:
|
Style/PreferredHashMethods:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 6
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/Proc:
|
||||||
Exclude:
|
Exclude:
|
||||||
- 'app/helpers/dropdowns_helper.rb'
|
- 'app/mailers/base_mailer.rb'
|
||||||
- 'app/models/application_setting.rb'
|
- 'app/models/label.rb'
|
||||||
- 'app/models/members/project_member.rb'
|
- 'app/models/service.rb'
|
||||||
- 'app/services/git_push_service.rb'
|
- 'lib/api/api_guard.rb'
|
||||||
- 'lib/api/helpers.rb'
|
- 'spec/initializers/trusted_proxies_spec.rb'
|
||||||
- 'lib/ci/api/builds.rb'
|
|
||||||
- 'lib/ci/gitlab_ci_yaml_processor.rb'
|
# Offense count: 21
|
||||||
- 'lib/gitlab/ci/config/node/configurable.rb'
|
# Cop supports --auto-correct.
|
||||||
- 'lib/gitlab/ci/config/node/factory.rb'
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
- 'lib/gitlab/google_code_import/client.rb'
|
# SupportedStyles: compact, exploded
|
||||||
- 'lib/gitlab/google_code_import/importer.rb'
|
Style/RaiseArgs:
|
||||||
- 'lib/gitlab/visibility_level.rb'
|
Enabled: false
|
||||||
- 'spec/requests/api/projects_spec.rb'
|
|
||||||
|
# Offense count: 3
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/RedundantBegin:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/ci/build.rb'
|
||||||
|
- 'app/models/merge_request.rb'
|
||||||
|
- 'app/services/projects/import_service.rb'
|
||||||
|
|
||||||
|
# Offense count: 1
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/RedundantException:
|
||||||
|
Exclude:
|
||||||
|
- 'app/helpers/preferences_helper.rb'
|
||||||
|
|
||||||
|
# Offense count: 21
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/RedundantFreeze:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 312
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/RedundantSelf:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 92
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles, AllowInnerSlashes.
|
||||||
|
# SupportedStyles: slashes, percent_r, mixed
|
||||||
|
Style/RegexpLiteral:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 14
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/RescueModifier:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 2
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/SelfAssignment:
|
||||||
|
Exclude:
|
||||||
|
- 'app/services/notification_service.rb'
|
||||||
|
- 'lib/api/runners.rb'
|
||||||
|
|
||||||
|
# Offense count: 2
|
||||||
|
# Configuration parameters: Methods.
|
||||||
|
# Methods: {"reduce"=>["a", "e"]}, {"inject"=>["a", "e"]}
|
||||||
|
Style/SingleLineBlockParams:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/commit.rb'
|
||||||
|
- 'spec/support/services_shared_context.rb'
|
||||||
|
|
||||||
|
# Offense count: 50
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: AllowIfMethodIsEmpty.
|
||||||
|
Style/SingleLineMethods:
|
||||||
|
Exclude:
|
||||||
|
- 'lib/ci/ansi2html.rb'
|
||||||
|
|
||||||
|
# Offense count: 14
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: space, no_space
|
||||||
|
Style/SpaceAroundEqualsInParameterDefault:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 118
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: space, no_space
|
||||||
|
Style/SpaceBeforeBlockBraces:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 11
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: AllowForAlignment.
|
||||||
|
Style/SpaceBeforeFirstArg:
|
||||||
|
Exclude:
|
||||||
|
- 'config/initializers/doorkeeper.rb'
|
||||||
|
- 'config/routes.rb'
|
||||||
|
- 'features/steps/project/source/browse_files.rb'
|
||||||
|
- 'features/steps/project/source/markdown_render.rb'
|
||||||
|
- 'spec/routing/project_routing_spec.rb'
|
||||||
|
- 'spec/services/delete_user_service_spec.rb'
|
||||||
|
- 'spec/services/projects/fork_service_spec.rb'
|
||||||
|
- 'spec/services/system_note_service_spec.rb'
|
||||||
|
|
||||||
|
# Offense count: 129
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
|
||||||
|
# SupportedStyles: space, no_space
|
||||||
|
Style/SpaceInsideBlockBraces:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 92
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/SpaceInsideBrackets:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 60
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/SpaceInsideParens:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
# Offense count: 5
|
# Offense count: 5
|
||||||
# Cop supports --auto-correct.
|
# Cop supports --auto-correct.
|
||||||
|
@ -63,3 +510,89 @@ Style/SpaceInsidePercentLiteralDelimiters:
|
||||||
Exclude:
|
Exclude:
|
||||||
- 'lib/event_filter.rb'
|
- 'lib/event_filter.rb'
|
||||||
- 'lib/gitlab/git_access.rb'
|
- 'lib/gitlab/git_access.rb'
|
||||||
|
|
||||||
|
# Offense count: 33
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: SupportedStyles.
|
||||||
|
# SupportedStyles: use_perl_names, use_english_names
|
||||||
|
Style/SpecialGlobalVars:
|
||||||
|
EnforcedStyle: use_perl_names
|
||||||
|
|
||||||
|
# Offense count: 30
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyle, SupportedStyles.
|
||||||
|
# SupportedStyles: single_quotes, double_quotes
|
||||||
|
Style/StringLiteralsInInterpolation:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 24
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: IgnoredMethods.
|
||||||
|
# IgnoredMethods: respond_to, define_method
|
||||||
|
Style/SymbolProc:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 23
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
|
||||||
|
# SupportedStyles: comma, consistent_comma, no_comma
|
||||||
|
Style/TrailingCommaInArguments:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 117
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: EnforcedStyleForMultiline, SupportedStyles.
|
||||||
|
# SupportedStyles: comma, consistent_comma, no_comma
|
||||||
|
Style/TrailingCommaInLiteral:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 7
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: AllowNamedUnderscoreVariables.
|
||||||
|
Style/TrailingUnderscoreVariable:
|
||||||
|
Exclude:
|
||||||
|
- 'app/controllers/admin/background_jobs_controller.rb'
|
||||||
|
- 'app/controllers/invites_controller.rb'
|
||||||
|
- 'app/controllers/projects/git_http_controller.rb'
|
||||||
|
- 'app/helpers/tab_helper.rb'
|
||||||
|
- 'lib/gitlab/force_push_check.rb'
|
||||||
|
- 'lib/gitlab/logger.rb'
|
||||||
|
|
||||||
|
# Offense count: 89
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/TrailingWhitespace:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 2
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
# Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
|
||||||
|
# Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
|
||||||
|
Style/TrivialAccessors:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/external_issue.rb'
|
||||||
|
- 'lib/gitlab/ldap/person.rb'
|
||||||
|
|
||||||
|
# Offense count: 3
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/UnlessElse:
|
||||||
|
Exclude:
|
||||||
|
- 'lib/api/projects.rb'
|
||||||
|
- 'lib/gitlab/backend/grack_auth.rb'
|
||||||
|
- 'lib/gitlab/project_search_results.rb'
|
||||||
|
|
||||||
|
# Offense count: 14
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/UnneededInterpolation:
|
||||||
|
Enabled: false
|
||||||
|
|
||||||
|
# Offense count: 8
|
||||||
|
# Cop supports --auto-correct.
|
||||||
|
Style/ZeroLengthPredicate:
|
||||||
|
Exclude:
|
||||||
|
- 'app/models/deploy_key.rb'
|
||||||
|
- 'app/models/network/commit.rb'
|
||||||
|
- 'app/models/network/graph.rb'
|
||||||
|
- 'app/models/project_services/asana_service.rb'
|
||||||
|
- 'app/models/repository.rb'
|
||||||
|
- 'lib/extracts_path.rb'
|
||||||
|
- 'lib/gitlab/force_push_check.rb'
|
||||||
|
|
Loading…
Reference in New Issue