kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Finish spec

Browse source
This commit is contained in:
Shinya Maeda 2017-08-22 21:42:17 +09:00
parent 03f72f0f41
commit fb8f32a92c
2 changed files with 7 additions and 17 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
lib/api/pipeline_schedules.rb
View file

@ -184,7 +184,7 @@ module API
not_found!('Variable') unless variable not_found!('Variable') unless variable
status :accepted status :accepted
present variable, with: Entities::Variable present variable.destroy, with: Entities::Variable
end end
end end

22
spec/requests/api/pipeline_schedules_spec.rb
View file

@ -330,7 +330,7 @@ describe API::PipelineSchedules do
end end
end end
context 'when cron has validation error' do context 'when key has validation error' do
it 'does not create pipeline_schedule_variable' do it 'does not create pipeline_schedule_variable' do
post api("/projects/#{project.id}/pipeline_schedules/#{pipeline_schedule.id}/variables", developer), post api("/projects/#{project.id}/pipeline_schedules/#{pipeline_schedule.id}/variables", developer),
params.merge('key' => '!?!?') params.merge('key' => '!?!?')
@ -368,23 +368,13 @@ describe API::PipelineSchedules do
end end
context 'authenticated user with valid permissions' do context 'authenticated user with valid permissions' do
it 'updates cron' do it 'updates pipeline_schedule_variable' do
put api("/projects/#{project.id}/pipeline_schedules/#{pipeline_schedule.id}/variables/#{pipeline_schedule_variable.key}", developer), put api("/projects/#{project.id}/pipeline_schedules/#{pipeline_schedule.id}/variables/#{pipeline_schedule_variable.key}", developer),
key: pipeline_schedule_variable.key, value: 'updated_value' value: 'updated_value'
expect(response).to have_http_status(:ok) expect(response).to have_http_status(:ok)
expect(response).to match_response_schema('pipeline_schedule_variable') expect(response).to match_response_schema('pipeline_schedule_variable')
expect(json_response['key']).to eq('updated_value') expect(json_response['value']).to eq('updated_value')
end
context 'when cron has validation error' do
it 'does not update pipeline_schedule_variable' do
put api("/projects/#{project.id}/pipeline_schedules/#{pipeline_schedule.id}/variables/#{pipeline_schedule_variable.key}", developer),
key: '!?!?'
expect(response).to have_http_status(:bad_request)
expect(json_response['message']).to have_key('key')
end
end end
end end
@ -412,7 +402,7 @@ describe API::PipelineSchedules do
create(:ci_pipeline_schedule, project: project, owner: developer) create(:ci_pipeline_schedule, project: project, owner: developer)
end end
let(:pipeline_schedule_variable) do let!(:pipeline_schedule_variable) do
create(:ci_pipeline_schedule_variable, pipeline_schedule: pipeline_schedule) create(:ci_pipeline_schedule_variable, pipeline_schedule: pipeline_schedule)
end end
@ -424,7 +414,7 @@ describe API::PipelineSchedules do
it 'deletes pipeline_schedule_variable' do it 'deletes pipeline_schedule_variable' do
expect do expect do
delete api("/projects/#{project.id}/pipeline_schedules/#{pipeline_schedule.id}/variables/#{pipeline_schedule_variable.key}", master) delete api("/projects/#{project.id}/pipeline_schedules/#{pipeline_schedule.id}/variables/#{pipeline_schedule_variable.key}", master)
end.to change { project.pipeline_schedules.count }.by(-1) end.to change { Ci::PipelineScheduleVariable.count }.by(-1)
expect(response).to have_http_status(:accepted) expect(response).to have_http_status(:accepted)
expect(response).to match_response_schema('pipeline_schedule_variable') expect(response).to match_response_schema('pipeline_schedule_variable')