From fbb529e46cfd031fae6f6f650d81bef331ef8fcd Mon Sep 17 00:00:00 2001 From: GitLab Bot Date: Mon, 10 Jan 2022 21:16:38 +0000 Subject: [PATCH] Add latest changes from gitlab-org/gitlab@master --- .../gitlab/delegate_predicate_methods.yml | 1 - .../javascripts/editor/source_editor.js | 2 +- .../shared/components/timezone_dropdown.js | 4 +- .../components/blob_button_group.vue | 25 +- .../components/blob_content_viewer.vue | 2 + .../components/delete_blob_modal.vue | 4 + .../repository/components/fork_suggestion.vue | 1 + .../components/upload_blob_modal.vue | 4 + app/finders/group_descendants_finder.rb | 16 +- .../linear_group_descendants_finder.yml | 8 - .../development/use_cmark_renderer.yml | 8 - doc/user/analytics/code_review_analytics.md | 18 +- .../merge_requests/commit_templates.md | 3 +- lib/banzai/filter/footnote_filter.rb | 62 +- .../filter/markdown_engines/common_mark.rb | 36 +- .../filter/markdown_post_escape_filter.rb | 18 +- lib/banzai/filter/plantuml_filter.rb | 7 +- lib/banzai/filter/sanitization_filter.rb | 19 +- lib/banzai/filter/syntax_highlight_filter.rb | 10 +- lib/banzai/renderer/common_mark/html.rb | 21 - .../html_pipeline_adapter.rb | 6 +- .../commit_message_generator.rb | 10 +- qa/knapsack/master_report.json | 404 ++--- spec/finders/group_descendants_finder_spec.rb | 382 ++-- spec/frontend/editor/source_editor_spec.js | 15 +- .../components/timezone_dropdown_spec.js | 6 +- .../components/blob_button_group_spec.js | 47 +- .../lib/banzai/filter/footnote_filter_spec.rb | 46 - .../lib/banzai/filter/markdown_filter_spec.rb | 163 +- .../lib/banzai/filter/plantuml_filter_spec.rb | 74 +- .../banzai/filter/sanitization_filter_spec.rb | 47 - .../filter/syntax_highlight_filter_spec.rb | 306 ++-- .../lib/banzai/pipeline/full_pipeline_spec.rb | 41 - .../pipeline/plain_markdown_pipeline_spec.rb | 174 +- spec/lib/gitlab/asciidoc_spec.rb | 1589 ++++++++--------- .../commit_message_generator_spec.rb | 69 +- spec/support/helpers/stub_gitlab_calls.rb | 7 +- 37 files changed, 1641 insertions(+), 2014 deletions(-) delete mode 100644 config/feature_flags/development/linear_group_descendants_finder.yml delete mode 100644 config/feature_flags/development/use_cmark_renderer.yml delete mode 100644 lib/banzai/renderer/common_mark/html.rb diff --git a/.rubocop_todo/gitlab/delegate_predicate_methods.yml b/.rubocop_todo/gitlab/delegate_predicate_methods.yml index 90f64e0d2e7..408eb6b6860 100644 --- a/.rubocop_todo/gitlab/delegate_predicate_methods.yml +++ b/.rubocop_todo/gitlab/delegate_predicate_methods.yml @@ -5,5 +5,4 @@ Gitlab/DelegatePredicateMethods: - app/models/concerns/integrations/base_data_fields.rb - app/models/project.rb - ee/app/models/concerns/ee/ci/metadatable.rb - - ee/app/models/license.rb - lib/gitlab/ci/trace/stream.rb diff --git a/app/assets/javascripts/editor/source_editor.js b/app/assets/javascripts/editor/source_editor.js index 57e2b0da565..fa749112ab5 100644 --- a/app/assets/javascripts/editor/source_editor.js +++ b/app/assets/javascripts/editor/source_editor.js @@ -149,7 +149,7 @@ export default class SourceEditor { }); this.instances.push(instance); - el.dispatchEvent(new CustomEvent(EDITOR_READY_EVENT, { instance })); + el.dispatchEvent(new CustomEvent(EDITOR_READY_EVENT, { detail: { instance } })); return instance; } diff --git a/app/assets/javascripts/pages/projects/pipeline_schedules/shared/components/timezone_dropdown.js b/app/assets/javascripts/pages/projects/pipeline_schedules/shared/components/timezone_dropdown.js index e92b9b30fa4..277d2e0d30a 100644 --- a/app/assets/javascripts/pages/projects/pipeline_schedules/shared/components/timezone_dropdown.js +++ b/app/assets/javascripts/pages/projects/pipeline_schedules/shared/components/timezone_dropdown.js @@ -1,6 +1,6 @@ import initDeprecatedJQueryDropdown from '~/deprecated_jquery_dropdown'; -const defaultTimezone = { name: 'UTC', offset: 0 }; +const defaultTimezone = { identifier: 'Etc/UTC', name: 'UTC', offset: 0 }; const defaults = { $inputEl: null, $dropdownEl: null, @@ -70,7 +70,7 @@ export default class TimezoneDropdown { setDropdownValue(timezone) { this.$dropdownToggle.text(this.displayFormat(timezone)); - this.$input.val(timezone.name); + this.$input.val(timezone.identifier); } handleDropdownChange({ selectedObj, e }) { diff --git a/app/assets/javascripts/repository/components/blob_button_group.vue b/app/assets/javascripts/repository/components/blob_button_group.vue index 6f540bf8ece..857795c71b0 100644 --- a/app/assets/javascripts/repository/components/blob_button_group.vue +++ b/app/assets/javascripts/repository/components/blob_button_group.vue @@ -1,5 +1,5 @@ @@ -107,14 +118,15 @@ export default { data-testid="lock" :data-qa-selector="lockBtnQASelector" /> - + {{ $options.i18n.replace }} - + {{ $options.i18n.delete }} diff --git a/app/assets/javascripts/repository/components/delete_blob_modal.vue b/app/assets/javascripts/repository/components/delete_blob_modal.vue index 0d3dc06c2c8..f3c9aea36f1 100644 --- a/app/assets/javascripts/repository/components/delete_blob_modal.vue +++ b/app/assets/javascripts/repository/components/delete_blob_modal.vue @@ -146,6 +146,9 @@ export default { /* eslint-enable dot-notation */ }, methods: { + show() { + this.$refs[this.modalId].show(); + }, submitForm(e) { e.preventDefault(); // Prevent modal from closing this.form.showValidation = true; @@ -164,6 +167,7 @@ export default {