Fix Rubocop failures
This commit is contained in:
parent
03144e1c0f
commit
fc061c2ecd
|
@ -1,5 +1,4 @@
|
||||||
class CreateRedirectRoutes < ActiveRecord::Migration
|
class CreateRedirectRoutes < ActiveRecord::Migration
|
||||||
|
|
||||||
# Set this constant to true if this migration requires downtime.
|
# Set this constant to true if this migration requires downtime.
|
||||||
DOWNTIME = false
|
DOWNTIME = false
|
||||||
|
|
||||||
|
|
|
@ -144,13 +144,13 @@ describe GroupsController do
|
||||||
it 'does not 404' do
|
it 'does not 404' do
|
||||||
delete :destroy, id: group.to_param.upcase
|
delete :destroy, id: group.to_param.upcase
|
||||||
|
|
||||||
expect(response).to_not have_http_status(404)
|
expect(response).not_to have_http_status(404)
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'does not redirect to the correct casing' do
|
it 'does not redirect to the correct casing' do
|
||||||
delete :destroy, id: group.to_param.upcase
|
delete :destroy, id: group.to_param.upcase
|
||||||
|
|
||||||
expect(response).to_not redirect_to(group_path(group.to_param))
|
expect(response).not_to redirect_to(group_path(group.to_param))
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
@ -190,13 +190,13 @@ describe GroupsController do
|
||||||
it 'does not 404' do
|
it 'does not 404' do
|
||||||
post :update, id: group.to_param.upcase, group: { path: 'new_path' }
|
post :update, id: group.to_param.upcase, group: { path: 'new_path' }
|
||||||
|
|
||||||
expect(response).to_not have_http_status(404)
|
expect(response).not_to have_http_status(404)
|
||||||
end
|
end
|
||||||
|
|
||||||
it 'does not redirect to the correct casing' do
|
it 'does not redirect to the correct casing' do
|
||||||
post :update, id: group.to_param.upcase, group: { path: 'new_path' }
|
post :update, id: group.to_param.upcase, group: { path: 'new_path' }
|
||||||
|
|
||||||
expect(response).to_not redirect_to(group_path(group.to_param))
|
expect(response).not_to redirect_to(group_path(group.to_param))
|
||||||
end
|
end
|
||||||
end
|
end
|
||||||
|
|
||||||
|
|
|
@ -68,7 +68,7 @@ describe 'Edit Project Settings', feature: true do
|
||||||
end
|
end
|
||||||
|
|
||||||
describe 'project features visibility pages' do
|
describe 'project features visibility pages' do
|
||||||
let(:tools) {
|
let(:tools) do
|
||||||
{
|
{
|
||||||
builds: namespace_project_pipelines_path(project.namespace, project),
|
builds: namespace_project_pipelines_path(project.namespace, project),
|
||||||
issues: namespace_project_issues_path(project.namespace, project),
|
issues: namespace_project_issues_path(project.namespace, project),
|
||||||
|
@ -76,7 +76,7 @@ describe 'Edit Project Settings', feature: true do
|
||||||
snippets: namespace_project_snippets_path(project.namespace, project),
|
snippets: namespace_project_snippets_path(project.namespace, project),
|
||||||
merge_requests: namespace_project_merge_requests_path(project.namespace, project),
|
merge_requests: namespace_project_merge_requests_path(project.namespace, project),
|
||||||
}
|
}
|
||||||
}
|
end
|
||||||
|
|
||||||
context 'normal user' do
|
context 'normal user' do
|
||||||
before do
|
before do
|
||||||
|
|
Loading…
Reference in New Issue