Fix uninitialized constant with GitLab Pages deploy

pages:deploy step was failing with the following error:

```
unitialized constant SafeZip::Extract::Zip
```

Since license_finder already pulls in rubyzip, we can make it
a required gem. We also use the scope operator to make the reference to
Zip::File explicit.
This commit is contained in:
Stan Hu 2019-01-29 07:49:59 -08:00 committed by Yorick Peterse
parent c0dbf23cb5
commit fc5ebc3cb8
No known key found for this signature in database
GPG Key ID: EDD30D2BEB691AC9
3 changed files with 7 additions and 2 deletions

View File

@ -57,7 +57,7 @@ gem 'u2f', '~> 0.2.1'
# GitLab Pages
gem 'validates_hostname', '~> 1.0.6'
gem 'rubyzip', '~> 1.2.2', require: false
gem 'rubyzip', '~> 1.2.2'
# Browser detection
gem 'browser', '~> 2.5'

View File

@ -0,0 +1,5 @@
---
title: Fix uninitialized constant with GitLab Pages
merge_request:
author:
type: fixed

View File

@ -29,7 +29,7 @@ module SafeZip
private
def extract_with_ruby_zip(params)
Zip::File.open(archive_path) do |zip_archive|
::Zip::File.open(archive_path) do |zip_archive|
# Extract all files in the following order:
# 1. Directories first,
# 2. Files next,