kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity

Disable password autocomplete in mirror repository form

Browse source 
Chrome and other browsers ignore `autocomplete=false` and
`autocomplete=off` now. This likely caused the mirroring section to
expand whenever a user clicked "Expand" in the protected branches
settings.

https://developers.google.com/web/fundamentals/design-and-ux/input/forms/?hl=en
recommends using `new-password` as the new field to prevent automatic
filling.

This is similar to
https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/8477.

Closes https://gitlab.com/gitlab-org/gitlab-ee/issues/11237
This commit is contained in:
Stan Hu 2019-04-21 16:16:33 -07:00
parent 10bf3bbc90
commit fd1bc613b4
2 changed files with 7 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
app/views/projects/mirrors/_mirror_repos.html.haml
View file

@ -11,7 +11,7 @@
= link_to _('Read more'), help_page_path('workflow/repository_mirroring'), target: '_blank' = link_to _('Read more'), help_page_path('workflow/repository_mirroring'), target: '_blank'
.settings-content .settings-content
= form_for @project, url: project_mirror_path(@project), html: { class: 'gl-show-field-errors js-mirror-form', autocomplete: 'false', data: mirrors_form_data_attributes } do |f| = form_for @project, url: project_mirror_path(@project), html: { class: 'gl-show-field-errors js-mirror-form', autocomplete: 'new-password', data: mirrors_form_data_attributes } do |f|
.panel.panel-default .panel.panel-default
.panel-heading .panel-heading
%h3.panel-title= _('Mirror a repository') %h3.panel-title= _('Mirror a repository')
@ -20,7 +20,7 @@
.form-group.has-feedback .form-group.has-feedback
= label_tag :url, _('Git repository URL'), class: 'label-light' = label_tag :url, _('Git repository URL'), class: 'label-light'
= text_field_tag :url, nil, class: 'form-control js-mirror-url js-repo-url qa-mirror-repository-url-input', placeholder: _('Input your repository URL'), required: true, pattern: "(#{protocols}):\/\/.+" = text_field_tag :url, nil, class: 'form-control js-mirror-url js-repo-url qa-mirror-repository-url-input', placeholder: _('Input your repository URL'), required: true, pattern: "(#{protocols}):\/\/.+", autocomplete: 'new-password'
= render 'projects/mirrors/instructions' = render 'projects/mirrors/instructions'

5
changelogs/unreleased/sh-fix-autocomplete-mirror-repo.yml Normal file
View file

@ -0,0 +1,5 @@
---
title: Disable password autocomplete in mirror repository form
merge_request: 27542
author:
type: fixed