Redirect to edit page on group transfer failure

This commit is contained in:
Illya Klymov 2019-04-02 04:14:19 +03:00
parent a374d690e7
commit ffbc66cc0b
3 changed files with 8 additions and 3 deletions

View File

@ -124,8 +124,8 @@ class GroupsController < Groups::ApplicationController
flash[:notice] = "Group '#{@group.name}' was successfully transferred."
redirect_to group_path(@group)
else
flash.now[:alert] = service.error
render :edit
flash[:alert] = service.error
redirect_to edit_group_path(@group)
end
end
# rubocop: enable CodeReuse/ActiveRecord

View File

@ -0,0 +1,5 @@
---
title: Group transfer now properly redirects to edit on failure
merge_request: 26837
author:
type: fixed

View File

@ -616,7 +616,7 @@ describe GroupsController do
end
it 'should redirect to the current path' do
expect(response).to render_template(:edit)
expect(response).to redirect_to(edit_group_path(group))
end
end