gitlab-org--gitlab-foss

Author SHA1 Message Date

Author	SHA1	Message	Date
Francisco Javier López	150f7c1e9c	Fix Bitbucket import In `ebf16ada85` we introduced a SHA validator, to ensure that the data provided in merge request diffs, was legit. Nevertheless, the validator assumed that the SHA should be 40 chars long. When we import a project from BitBucket, the retrieved SHA is shorter (12 chars long). Therefore, this validator prevented to create a valid MergeRequestDiff for ever MergeRequest (triggering an exception).	2019-03-14 10:05:17 +00:00
Francisco Javier López	ebf16ada85	Arbitrary file read via MergeRequestDiff	2019-03-04 18:36:34 +00:00

Francisco Javier López

150f7c1e9c

Fix Bitbucket import

In ebf16ada85
we introduced a SHA validator, to ensure that the data provided in
merge request diffs, was legit. Nevertheless, the validator
assumed that the SHA should be 40 chars long.

When we import a project from BitBucket, the retrieved SHA is
shorter (12 chars long). Therefore, this validator prevented to
create a valid MergeRequestDiff for ever MergeRequest (triggering
an exception).

2019-03-14 10:05:17 +00:00

Francisco Javier López ebf16ada85 Arbitrary file read via MergeRequestDiff 2019-03-04 18:36:34 +00:00

2 Commits