Commit graph

8 commits

Author SHA1 Message Date
Robert Speicher
34c083a184 Merge branch 'rubocop/enable-access-modifiers-cops' into 'master'
Enable Rubocop cops that check access modifiers

## What does this MR do?

This MR enables Rubocop cops that detect methods that should be restricted but are the part of public API because of access modifiers used improperly.

This also fixes existing offenses.

## Why was this MR needed?

Some method in our codebase are public instead of being private because it is sometimes difficult to get it right without static analysis.

## What are the relevant issue numbers?

See #17478  
Closes #17372 

See merge request !5014
2016-07-29 15:58:09 +00:00
Grzegorz Bizon
07be594378 Enable Style/MultilineTernaryOperator rubocop cop
Avoid multi-line ?: (the ternary operator). Use if/unless instead.

See #17478
2016-07-20 14:24:39 +02:00
Grzegorz Bizon
d6f6697744 Enable Rubocop cops for invalid access modifiers
This enables following cops:

Check for useless access modifiers

  Lint/UselessAccessModifier

Checks for attempts to use `private` or `protected` to set the
visibility of a class method, which does not work.

  Lint/IneffectiveAccessModifier

This also disables two false possitives in concerns.
2016-07-19 15:12:15 +02:00
Connor Shea
82c500a2b6
Disable all cops with offenses. 2016-07-13 12:39:14 -06:00
Connor Shea
9468b07925
Resolve feedback. 2016-07-13 12:12:47 -06:00
Connor Shea
c4cbf3effa
Disable two cops as recommended. 2016-07-13 12:12:47 -06:00
Connor Shea
fb4f3a473b
Remove some disabled cops. 2016-07-13 12:12:47 -06:00
Z.J. van de Weg
ae6edf18fc
Update rubocop to 0.41.2
https://github.com/bbatsov/rubocop/blob/v0.41.2/CHANGELOG.md
2016-07-13 12:12:47 -06:00