Commit graph

29 commits

Author SHA1 Message Date
Douwe Maan
56de781a2c Revert "Enable Style/DotPosition"
This reverts commit e00fb2bdc2090e9cabeb1eb35a2672a882cc96e9.

# Conflicts:
#	.rubocop.yml
#	.rubocop_todo.yml
#	lib/gitlab/ci/config/entry/global.rb
#	lib/gitlab/ci/config/entry/jobs.rb
#	spec/lib/gitlab/ci/config/entry/factory_spec.rb
#	spec/lib/gitlab/ci/config/entry/global_spec.rb
#	spec/lib/gitlab/ci/config/entry/job_spec.rb
#	spec/lib/gitlab/ci/status/build/factory_spec.rb
#	spec/lib/gitlab/incoming_email_spec.rb
2017-02-23 09:33:19 -06:00
Douwe Maan
1fe7501b49 Revert "Prefer leading style for Style/DotPosition"
This reverts commit cb10b725c8929b8b4460f89c9d96c773af39ba6b.
2017-02-23 09:33:05 -06:00
Douwe Maan
e2bbbb1a9a Fix new offenses 2017-02-23 09:32:42 -06:00
Douwe Maan
206953a430 Prefer leading style for Style/DotPosition 2017-02-23 09:32:22 -06:00
Robert Speicher
80a6d2fda2 Use :empty_project where possible throughout spec/lib 2017-01-25 12:25:42 -05:00
Valery Sizov
5b0ebbe5b4 Add Wiki import to BB importer 2016-12-19 20:48:08 +02:00
Valery Sizov
c756e62b08 BB importer: fix specs 2016-12-14 20:19:26 +02:00
Valery Sizov
314c4746bc Specs for Bitbucket::Connections and Bitbucket::Collections 2016-12-12 16:16:51 +02:00
Valery Sizov
ff2193a3db Fix specs 2016-12-09 19:40:22 +02:00
Stan Hu
7a155137a4 Fix spec for Bitbucket importer 2016-11-21 22:06:09 -08:00
Stan Hu
fc40c3f28a Fix Rubocop errors with Bitbucket Importer spec 2016-11-21 20:58:46 -08:00
Stan Hu
402cc95c1a Fix Bitbucket importer spec to pass with 2.0 API 2016-11-21 20:49:40 -08:00
Stan Hu
2747e515c6 Fix BitbucketImport::ProjectCreator spec 2016-11-21 16:47:30 -08:00
Stan Hu
f25d64d41a Remove no longer used BitbucketImport::Client spec 2016-11-21 16:47:29 -08:00
Stan Hu
328da189d2 Fix spec to set import_url before attempting to create import_data 2016-07-17 20:57:11 -07:00
Kamil Trzcinski
13d941e185 Make Omniauth providers specs to not modify global configuration 2016-06-08 16:50:05 +02:00
Robert Speicher
75739e54be Enable RSpec/NotToNot cop and auto-correct offenses
Also removes the note from the development/testing.md guide
2016-05-24 15:40:29 -04:00
James Lopez
9a9681772c fix failing spec 2016-04-28 11:40:23 +02:00
James Lopez
8793025dd0 added spec testing exception raised 2016-04-28 10:26:44 +02:00
James Lopez
8aafe68583 first round of fixes and spec fixes 2016-03-22 17:53:53 +01:00
Iuri de Silvio
591bf92ce7 Fix bug where Bitbucket closed issues were imported as opened 2016-03-07 19:23:47 +01:00
Douwe Maan
13d6bab177 Tag lib specs 2015-12-09 11:55:42 +01:00
Stan Hu
2e9c922dd1 Fix bug where only the first 15 Bitbucket issues would be imported.
Also fix a number of issues where author/reporter names were not available.
2015-09-01 08:50:20 -07:00
Stan Hu
ed1d4fa477 Remove user OAuth tokens stored in database for Bitbucket, GitHub, and GitLab
and request them each session. Pass these tokens to the project import data.

This prevents the need to encrypt these tokens and clear them in case they
expire or get revoked.

For example, if you deleted and re-created OAuth2 keys for Bitbucket, you would get
an Error 500 with no way to recover:

```
Started GET "/import/bitbucket/status" for x.x.x.x at 2015-08-07 05:24:10 +0000
Processing by Import::BitbucketController#status as HTML
Completed 500 Internal Server Error in 607ms (ActiveRecord: 2.3ms)

NameError (uninitialized constant Import::BitbucketController::Unauthorized):
  app/controllers/import/bitbucket_controller.rb:77:in `rescue in go_to_bitbucket_for_permissions'
  app/controllers/import/bitbucket_controller.rb:74:in `go_to_bitbucket_for_permissions'
  app/controllers/import/bitbucket_controller.rb:86:in `bitbucket_unauthorized'
```

Closes #1871
2015-08-23 09:23:44 -07:00
Robert Speicher
15a05be70d Fix Style/Blocks cop violations 2015-06-22 16:00:54 -04:00
Robert Speicher
94eff65569 Fix Style/SpaceInsideHashLiteralBraces cop violations
These fixes were performed automatically by Rubocop's `-a` flag.
2015-06-22 14:41:00 -04:00
Douwe Maan
80097606f5 Make sure user has access to namespace in import tests. 2015-04-15 16:58:43 +02:00
Stan Hu
5cce0645b0 Fix OAuth2 issue importing a new project from GitHub and GitLab
Closes #1268
2015-03-22 18:16:48 -07:00
Douwe Maan
ad6d623234 Add Bitbucket importer. 2015-02-24 15:07:24 +01:00