20fdbbe86a
Use Goldiloader for handling N+1 queries
...
Goldiloader (https://github.com/salsify/goldiloader ) can eager load
associations automatically. This removes the need for adding "includes"
calls in a variety of different places. This also comes with the added
benefit of not having to eager load data if it's not used.
2018-04-09 11:58:06 +01:00
a93ccf0710
Properly cleaning up memoized values
2018-01-12 17:54:55 +08:00
4f00a05152
Introduce PredicateMemoization cop and fix offenses
...
with StrongMemoize
2018-01-12 17:54:55 +08:00
07d3d44775
Move ModuleWithInstanceVariables to Gitlab namespace
...
And use .rubocop.yml to exclude paths we don't care,
rather than using the cop itself to exclude.
2017-11-22 17:06:57 +08:00
9ac0c76b78
Use StrongMemoize and enable/disable cops properly
2017-11-18 01:01:53 +08:00
f8b681f6e9
WIP
2017-11-06 22:40:19 +08:00
6a4ee9aa71
Allow simple ivar ||= form. Update accordingly
2017-09-19 01:29:32 +08:00
9ae92b8caa
Add cop to make sure we don't use ivar in a module
2017-09-18 21:23:45 +08:00
e8f29569bc
Resolve outdated diff discussions on push
2017-09-06 10:08:03 +01:00
cc656a1199
Refactor resolvability checks based on type
2017-04-06 10:51:45 -05:00
c319f21141
Address review comments
2017-04-05 17:44:14 +01:00
21e10888c3
Address review comments
2017-04-05 17:44:14 +01:00
2058e71e63
Extract commonalities between DiffDiscussion and LegacyDiffDiscussion
2017-04-05 17:44:14 +01:00
Yorick Peterse