Commit graph

24 commits

Author SHA1 Message Date
Nick Thomas
ba0ebbb510 Allow the git circuit breaker to correctly handle missing repository storages 2017-09-22 10:05:28 +01:00
Bob Van Landuyt
eb63889f7c Don't memoize storage configuration on FsShardsCheck
These values are already coming from memory, so we don't need to
memoize.

If we do memoize these, than the would not be stubbed when calling
`stub_storage_settings` in specs
2017-09-21 16:15:08 +02:00
Nick Thomas
b00aaeced7 Fix the filesystem shard health check to check all configured shards 2017-09-19 11:05:42 +01:00
Maxim Rydkin
622c912d5b replace is_successful? with successful? 2017-08-29 11:14:42 +03:00
Bob Van Landuyt
3598e60bf2 Add a Circuitbreaker for storage paths 2017-08-04 15:38:48 +02:00
Pawel Chojnacki
9be1732296 add comment explaining use of shell commands and file operations in the same methods 2017-07-27 15:44:13 +02:00
Pawel Chojnacki
6ac0a142e0 Remove unnecessary begin/end 2017-07-26 17:16:59 +02:00
Pawel Chojnacki
7ce0a61a99 use .zero? instead of == 0 2017-07-26 13:23:27 +02:00
Pawel Chojnacki
895e1b3ed1 Stop abusing subject to store results,
+ add helper methods to cleanup fs_shards metrics
2017-07-26 00:28:13 +02:00
Pawel Chojnacki
37f27079fe Fix redis check with_timing method usage 2017-07-25 15:17:05 +02:00
Pawel Chojnacki
b1d6670d04 Add Changelog about temp file removal fix
+ remove whitespace
2017-07-25 14:34:39 +02:00
Pawel Chojnacki
2286879583 Ensure test files are deleted after tests 2017-07-25 14:19:09 +02:00
Ben Kochie
86cbef4df4 Add unit to latency metrics.
Add `seconds` unit to latency metrics based on uptream naming
convention[0].

[0]: https://prometheus.io/docs/practices/naming/#metric-names
2017-07-12 14:48:46 +02:00
Paul Charlton
cb3b4a15e6 Support multiple Redis instances based on queue type 2017-07-11 03:35:47 +00:00
Stan Hu
804b61eb7a Fix invalid Rails.logger call in lib/gitlab/health_checks/fs_shards_check.rb 2017-07-04 23:22:59 -07:00
Pawel Chojnacki
0edc1ef675 Use key? instead of has_key? method 2017-06-07 14:37:32 +02:00
Pawel Chojnacki
d26573c6e3 Make PrometheusTextFormat return proper output terminated with '\n'
remove file dangling after rebase
2017-06-02 19:48:39 +02:00
Pawel Chojnacki
7b75004d60 Add missing trailing newlines 2017-06-02 19:45:58 +02:00
Pawel Chojnacki
b668aaf426 Split the metrics implementation to separate modules for Influx and Prometheus 2017-06-02 19:45:58 +02:00
Pawel Chojnacki
ae8f7666e5 Add prometheus text formatter
+ rename controler method to #index from #metrics
 + remove assertion from nullMetric
2017-06-02 19:45:58 +02:00
Pawel Chojnacki
c134a72cdb Move Prometheus presentation logic to PrometheusText
+ Use NullMetrics to mock metrics when unused
+ Use method_missing in NullMetrics mocking
+ Update prometheus gem to version that correctly uses transitive dependencies
+ Ensure correct folders are used in Multiprocess prometheus client tests.
+ rename Sessions controller's metric
2017-06-02 19:45:58 +02:00
Pawel Chojnacki
a0497a7bc0 Move helpers to spec file, use const's instead of helper methods 2017-05-25 21:59:57 +02:00
Pawel Chojnacki
6ced4d138e Fix transient CI errors by increasing command execution timeouts from 1s to 30s
+ actually make local tests correctly detect wether 'timeout' or 'gtimeout' is available
2017-05-17 16:22:47 +02:00
Paweł Chojnacki
c3e43c9ba3 Add /-/readiness /-/liveness and /-/health_metrics endpoints to track application readiness 2017-04-07 10:27:15 +00:00