Clement Ho
|
9ba8685ea7
|
Merge branch 'master' into 'docs-specific-review-examples'
# Conflicts:
# doc/development/code_review.md
|
2017-08-01 18:23:36 +00:00 |
|
Marin Jankovski
|
0430007ec8
|
Add code review guidelines related to Build [CI skip].
|
2017-08-01 14:01:48 +00:00 |
|
Clement Ho
|
c4e7875d29
|
Add note about UX paradigm
|
2017-07-31 15:19:51 -05:00 |
|
Clement Ho
|
fac3c91728
|
Add specific code review guidelines
|
2017-07-31 14:00:52 -05:00 |
|
Sean McGivern
|
e597fa613d
|
Add GitLab-specific concerns to code review guide
|
2017-07-24 14:12:39 +01:00 |
|
Sean McGivern
|
4b463dcb8d
|
Fix links in code review docs
|
2017-05-09 14:41:06 +01:00 |
|
Rémy Coutable
|
38c29f8775
|
Improving copy of CONTRIBUTING.md, PROCESS.md, and code_review.md
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
2017-05-04 09:02:39 +02:00 |
|
Rémy Coutable
|
f644b8c80a
|
Improve the Code review guidelines documentation
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
2017-05-03 18:25:20 +02:00 |
|
Achilleas Pipinellis
|
a084437b5c
|
Rename builds to jobs in docs
[ci skip]
|
2017-02-15 12:12:35 +01:00 |
|
Sean McGivern
|
e2585e642a
|
Rename endboss -> maintainer, miniboss -> reviewer
We want to describe these roles in a way that is more understandable to
people not familiar with GitLab.
|
2017-01-13 16:12:02 +00:00 |
|
Kamil Trzciński
|
0f90fd639c
|
Merge branch 'fix/rename-mwbs-to-merge-when-pipeline-succeeds' into 'master'
Rename MWBS service to Merge When Pipeline Succeeds
## What does this MR do?
This MR renames Merge When Build Succeeds feature to Merge When Pipeline Succeeds, because we recently changed the behavior, see https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6675.
## Does this MR meet the acceptance criteria?
- [x] [CHANGELOG](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/CHANGELOG.md) entry added
- [x] [Documentation created/updated](https://gitlab.com/gitlab-org/gitlab-ce/blob/master/doc/development/doc_styleguide.md)
- [x] All builds are passing
## What are the relevant issue numbers?
Closes #23354
See merge request !7135
|
2016-12-05 11:07:57 +00:00 |
|
Grzegorz Bizon
|
ebef1a8441
|
Remove change to MWBS in code review guideline
[ci skip]
|
2016-12-02 08:55:53 +01:00 |
|
Grzegorz Bizon
|
85c4aa4a67
|
Copy-edit text about right balance in code reviews
[ci skip]
|
2016-12-01 10:42:35 +01:00 |
|
Grzegorz Bizon
|
5b052605b7
|
Extend code review docs with chapter about the right balance
|
2016-11-30 11:23:09 +01:00 |
|
Grzegorz Bizon
|
c6a4f9fc5b
|
Update some docs to reflect MWPS name change
|
2016-11-21 11:27:28 +01:00 |
|
Rémy Coutable
|
52ca9bf600
|
Fix typo and add he MWBS accronym for "Merge When Build Succeeds"
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
2016-10-07 16:17:28 +02:00 |
|
Rémy Coutable
|
2f7e28d1f7
|
Improve the contribution and MR review guide
Signed-off-by: Rémy Coutable <remy@rymai.me>
|
2016-10-07 15:28:15 +02:00 |
|
Robert Speicher
|
0c6923e2d1
|
Re-add a note about sarcasm to the Code Review guide
[ci skip]
|
2016-04-10 22:54:44 -04:00 |
|
Robert Speicher
|
c7ec5929b1
|
First pass at a Code Review guide
Largely borrowed from thoughtbot's code review guide, so attribution is
included.
[ci skip]
|
2016-04-09 21:49:47 -04:00 |