blackst0ne
236876f278
Update specs to exclude possible false positive pass
2018-12-18 10:21:30 +11:00
George Tsiolis
733ae94921
Fix typos in comments and specs
2018-11-01 08:59:20 +02:00
Stan Hu
36a8f1a677
Reject GPG keys that have e-mail or names with non-valid UTF-8 encodings
...
These were causing 500 Errors when accessing GPG keys for some users.
Closes https://gitlab.com/gitlab-org/gitlab-ce/issues/47280
2018-06-05 14:39:44 -07:00
Rubén Dávila
555f50b3e6
Add more specs.
2017-10-05 22:43:44 -05:00
Alexis Reigel
2a89037b63
downcase gpg key's emails
...
this is necessary for email comparisons
2017-09-05 12:18:31 +02:00
Alexis Reigel
edcc488b75
use mutex for keychain interaction
...
setting of the gpg home directory is not thread safe, as the directoy
gets stored on the class.
if multiple threads change the directory at the same time, one of the
threads will be working in the wrong directory.
2017-08-14 12:57:56 +02:00
Alexis Reigel
6cd9888f6f
store gpg return directory locally
2017-08-11 08:38:42 +02:00
Alexis Reigel
cd01e82873
store gpg user name and email on the signature
2017-07-27 15:44:39 +02:00
Alexis Reigel
deb474b413
extract common method
2017-07-27 15:43:37 +02:00
Alexis Reigel
e9515dff84
remove the :gpg rspec tag
...
since everything (except the CurrentKeyChain method) operates on a
tempoary keychain anyway we don't need this anymore.
2017-07-27 15:43:37 +02:00
Alexis Reigel
2f956fae03
verify gpg commit using tmp keyring and db query
2017-07-27 15:42:53 +02:00
Alexis Reigel
3c42d73098
add primary keyid attribute to gpg keys
2017-07-27 15:42:53 +02:00
Alexis Reigel
7e13d96715
don't sync to keychain file
2017-07-27 15:42:53 +02:00
Alexis Reigel
0668521b2b
move current keychain methods to namespace
2017-07-27 15:40:41 +02:00
Alexis Reigel
0e3d3d60ba
email handling for gpg keys
2017-07-27 15:40:41 +02:00
Alexis Reigel
5ce61120b1
use example gpg key instead of my own
2017-07-27 15:40:41 +02:00
Alexis Reigel
eb77e1068c
add second gpg key for specs
2017-07-27 15:40:41 +02:00
Alexis Reigel
87c0fd3455
add / remove gpg keys to / from system keychain
2017-07-27 15:40:41 +02:00
Alexis Reigel
e34cef0cd2
extract gpg functionality to lib class
2017-07-27 15:40:41 +02:00
