Commit graph

28 commits

Author SHA1 Message Date
Gabriel Mazetto
8f178c4222 Prevent new / renamed project from using a repository path that already exists on disk
There are some redundancies in the validation steps, and that is to
preserve current error messages behavior

Also few specs have to be changed in order to fix madness in validation
logic.
2017-08-25 20:06:06 +02:00
Robert Speicher
72a7b30c9f Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
Douwe Maan
ce869e3964 Fix Diff#too_large? and specs 2017-05-30 21:48:30 -05:00
Douwe Maan
aed0387f97 Consistent diff and blob size limit names 2017-05-29 17:02:02 -05:00
Douwe Maan
b0a163208c Rename BlobViewer max_size to overridable_max_size and absolute_max_size to max_size 2017-05-15 10:03:34 -05:00
Douwe Maan
acffc06213 Specify explicitly whether a blob viewer should be loaded asynchronously 2017-05-13 11:46:10 -05:00
Douwe Maan
720cc14a75 Refactor Blob support of external storage in preparation of job artifact blobs 2017-05-03 10:20:05 -05:00
Douwe Maan
60ebd101d0 Use blob viewers for snippets 2017-04-30 11:21:20 -05:00
Douwe Maan
87a3bd26fa Address feedback 2017-04-27 12:23:27 -05:00
Douwe Maan
dc4726f0a7 Satisfy Rubocop 2017-04-27 12:23:27 -05:00
Douwe Maan
964e7d206b Add specs 2017-04-27 12:23:26 -05:00
Douwe Maan
a6536a84e7 Fix some specs 2017-04-27 12:23:26 -05:00
Eric Eastwood
b42dc1a52b Linking to edit file directly 2017-04-06 16:36:38 +00:00
Douwe Maan
f90909307e Fix specs 2017-03-14 15:29:31 -06:00
Robert Speicher
2fe13fbc4b Use :empty_project where possible in helper specs 2017-01-25 17:10:32 -05:00
Paco Guzman
938f3b2a0b edit_blob_link can receive the blob to avoid access to the repository 2016-08-18 16:30:25 +02:00
tiagonbotelho
519275c110 fixes part1 of files to start using active tense 2016-08-09 15:06:23 +01:00
Stan Hu
48ff40a047 Improve diff performance by eliminating redundant checks for text blobs
On a merge request with over 1000 changed files, there were redundant
calls to blob_text_viewable?, which incurred about 7% of the time.

Improves #14775
2016-07-29 21:06:50 -07:00
http://jneen.net/
c4ea394736 use %(...) and %[...] in favor of %<...> 2016-07-14 22:43:49 -07:00
http://jneen.net/
e0ee9dacd1 remove uses of the nowrap: feature 2016-07-14 10:08:16 -07:00
http://jneen.net/
001b1ff312 rm spec for a deleted method 2016-07-14 10:08:15 -07:00
Stan Hu
21d89d0286 Update SVG sanitizer to conform to SVG 1.1
Use a custom Loofah scrubber since sanitize 2.x transformers are inadequate
to handle case-sensitive SVG attributes. sanitize parses documents as HTML
instead of XML, which causes all SVG attribute names (e.g. viewBox) to be downcased.

* SVG element list: https://www.w3.org/TR/SVG/eltindex.html
* SVG attribute list: https://www.w3.org/TR/SVG/attindex.html

Closes #14555
2016-05-06 23:20:24 -07:00
Douwe Maan
512bebe21d Refactor Gitlab::Highlight and fix tests 2016-01-19 14:52:41 +01:00
Rubén Dávila
bb96d63153 New implementation for highlighting diff files. #3945
* It is more performant given now we process all the diff file instead
  of processing line by line.
* Multiline comments are highlighted correctly.
2015-12-30 00:52:50 -05:00
Rubén Dávila
34657b821a Add syntax highlighting to diff view. #3945 2015-12-28 18:31:27 -05:00
Stan Hu
15d5dfdb33 Fix diff syntax highlighting
Refactored HTML parser to avoid duplication of newline parsing.

Closes #2235
2015-08-10 08:07:26 -07:00
Stan Hu
0abe98f049 Fix multi-line syntax highlighting
HTML span elements only apply to a single line, and in the case of multi-line
comments, the highlighting was dropped as a result. Ensure that each line has
the proper styling to fix this.

Closes #1577
2015-07-30 22:37:53 -07:00
Stan Hu
0cd73885e6 Fix git blame syntax highlighting when different commits break up lines
Closes #1521
2015-05-27 14:10:58 -07:00