Dmitriy Zaporozhets
2eec0b73e8
Fix submodule link to then project under subgroup
...
Before this change only last namespace in full path was extracted. It's
fine unless you have a link to submodule under subgroups. In that case
self_url? method returns false and link is processed as external. I
could not find a proper regex to cover all cases and correctly extract
full path to repository and instead used current instance host name
to get correct path to namespace and project.
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-06-05 09:26:20 +03:00
Stan Hu
59b8165c90
Strip trailing whitespaces in submodule URLs
...
Users attempting to access repositories that had `.gitmodules` entries
with trailing whitespaces would encounter an Error 500. This was due
to a change in bf876ec7 that quietly removed the whitespace stripping.
Closes #33018
2017-05-29 06:16:47 -07:00
David Turner
897a85a461
submodule_links: Handle in-repository submodule urls
...
Sometimes it is useful to store submodules in the same repository which
contains links to them. Make the UI support this.
See
https://github.com/twosigma/git-meta/wiki/The-Omega-Repo
for information about this strategy
Signed-off-by: David Turner <novalis@novalis.org>
2017-05-15 16:04:46 -04:00
Douwe Maan
9ae401cf91
Merge branch 'rs-sanitize-submodule-urls' into 'security'
...
Sanitize submodule URLs before linking to them in the file tree view
See merge request !2084
2017-05-10 16:44:20 +02:00
David Turner
040062cc8a
submodule_links: handle urls that don't end with .git
...
Signed-off-by: David Turner <novalis@novalis.org>
2017-04-21 10:54:31 -04:00
Douwe Maan
5c7f9d69e3
Fix code for cops
2017-02-23 09:31:57 -06:00
Douwe Maan
c10064aad5
Enable Style/SpaceInsideBrackets
2017-02-23 09:31:56 -06:00
Dmitriy Zaporozhets
6676b4f0dd
Use Namespace#full_path instead of Namespace#path
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2017-02-14 18:38:20 +02:00
Stan Hu
774b7ee277
Fix Error 500 when relative submodule resolves to a namespace that has a different name from its path
...
Closes #1849
2015-06-23 05:49:19 -07:00
Stan Hu
72a7febead
Fix "Revspec not found" errors when viewing diffs in a forked project with submodules
...
Closes #1413
2015-04-27 20:42:38 -07:00
Stan Hu
9a2e3d3d81
Fix broken file browsing with relative submodule in personal projects
...
Closes https://github.com/gitlabhq/gitlabhq/issues/7554
2015-04-23 07:42:28 -07:00
Dmitriy Zaporozhets
f244914402
Merge branch 'regex-start-of-string' into 'master'
...
Fix persistent XSS vulnerability around profile website URLs.
Fixes gitlab/gitlab-ee#268
See merge request !1761
2015-04-12 07:36:40 +00:00
Douwe Maan
0ece6bd828
Use \A and \z in regexes instead of ^ and $.
2015-04-10 18:31:07 +02:00
Stan Hu
7d089701f1
Fix broken file browsing with a submodule that has a relative link
...
Closes #775
2015-04-09 22:10:59 -07:00
Dmitriy Zaporozhets
69454e36f7
Style/RedundantReturn enabled
2015-03-24 18:35:57 -07:00
Vinnie Okada
76aad9b76e
Upgrade to Rails 4.1.9
...
Make the following changes to deal with new behavior in Rails 4.1.2:
* Use nested resources to avoid slashes in arguments to path helpers.
2015-02-14 11:09:23 -07:00
Headless
3d2aaa169e
show diff in submodules
2015-01-19 17:18:08 +03:00
Dmitriy Zaporozhets
0fdce4a52b
Refactor some search scopes to prevent wierd behaviour and PG::Error issues
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-06-05 20:37:35 +03:00
Timm Drevensek
c0744e5ba0
simplify link url
2014-02-28 17:22:07 +01:00
Timm Drevensek
e935635620
fixed regex to match url pointing to a user repo
2014-02-26 23:33:04 +01:00
Timm Drevensek
fe8c902126
Add support for relative submodules
2014-02-25 22:42:45 +01:00
Dmitriy Zaporozhets
bed05a1381
Fix submodule_helper specs
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-02-10 13:02:26 +02:00
Dmitriy Zaporozhets
dee11dadad
Fix submodules
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2014-02-10 09:55:38 +02:00
Jason Hollingsworth
fcc906e6aa
Better submodule links.
...
Detect if submodule is hosted on this GitLab server, gitlab.com or github.com.
Hash links directly to commit in repo.
2014-02-05 20:44:14 -06:00
