Commit graph

19 commits

Author SHA1 Message Date
Kamil Trzcinski
c4e46c5740 Fix success status 2016-12-07 12:47:06 +01:00
Kamil Trzcinski
260d754ca8 Fix handling of allowed to failure jobs 2016-12-06 14:13:21 +01:00
Kamil Trzcinski
6d80b94a89 Fix handling of skipped vs success status 2016-12-06 14:13:21 +01:00
Kamil Trzcinski
ca639c9b82 Allow to retry failed or canceled builds and fix cancel running specs failure 2016-11-19 14:04:11 +01:00
Lin Jen-Shin
6d1c5761cd Improve how we could cancel pipelines:
* Introduce `HasStatus.cancelable` which we might be able to cancel
* Cancel and check upon `cancelable`
* Also cancel on `CommitStatus` rather than just `Ci::Build`

Fixes #23635

Fixes #17845
2016-11-17 20:22:57 +08:00
Annabel Dunstone Gray
d61f8a18e0 Move build order array to HasStatus module 2016-10-18 08:29:29 -05:00
Lin Jen-Shin
5c9ac560e7 Introduce all_state_names so that we could avoid NOT IN 2016-10-05 00:10:23 +08:00
Lin Jen-Shin
7fb6a73db5 We don't need self. there. (sorry, can't resist anymore) 2016-10-03 19:49:53 +08:00
Lin Jen-Shin
afc0ae5cbe Fix tests. Check 'success' first (default status) 2016-10-03 19:35:53 +08:00
Lin Jen-Shin
9c2306006c Remove dead code 2016-10-03 18:35:36 +08:00
Lin Jen-Shin
8dfec32d2b Rename ignored to failed_but_allowed, introduce exclude_ignored
which merges previous exclude_ignored_jobs and failed_but_allowed,
so that we don't treat ignored a special case in HasStatus.
2016-10-03 18:22:51 +08:00
Lin Jen-Shin
f0002da09c Add a test for on_failure jobs in the middle 2016-10-01 14:38:39 +08:00
Lin Jen-Shin
33bbfd277b on_failure should also be ignored, and status_sql should
also respect this ignorance. Address feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6604#note_16273363
2016-10-01 14:17:54 +08:00
Lin Jen-Shin
f3b02b9e6e Or we could simply ignore skipped manual jobs 2016-09-30 18:39:08 +08:00
Lin Jen-Shin
6053acf5e6 We consider skipped = success, fixes #22598 2016-09-30 03:41:38 +08:00
Kamil Trzcinski
e0f90fb2de Return created status 2016-09-18 20:39:44 +02:00
Lin Jen-Shin
50e62b3eb8 Fix Commit#status, feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/6305#note_15230024
2016-09-14 01:25:26 +08:00
Lin Jen-Shin
47dccfb329 Fix test (credits to Kamil) 2016-09-12 20:22:59 +08:00
De Wet Blomerus
23bed91b3f rename Statuseable to HasStatus 2016-08-25 04:55:32 +02:00
Renamed from app/models/concerns/statuseable.rb (Browse further)