Commit Graph

7 Commits

Author SHA1 Message Date
Lin Jen-Shin 566caff731 Add render_if_exists to variable env scope 2018-06-09 01:36:25 +08:00
Lin Jen-Shin 0446419a83 Use qa selectors for secret variables
The problem of using .js-ci-variable-input-value is that,
whenever the value is hidden, then this selector won't be set,
instead, .js-secret-value-placeholder would be set.

If we just fill the value, the value is revealed. But if
we visit this later, the values were be hidden. This means
we don't have a consistent way to count the values.

Adding an unique qa selector to both revealed and hidden
values would make it easier to track the values.

To make it look more consistent, let's also do the same
for the key.
2018-04-21 01:18:18 +08:00
Eric Eastwood d5f0d89f9d Remove EE-specific comments from CE 2018-03-28 11:05:14 -05:00
Matija Čupić 05103f080c
Make Variable key not secret 2018-03-22 12:08:16 +01:00
Matija Čupić 763c82f0b3
Use secret_key and secret_value in variable form field names 2018-03-16 16:59:06 +01:00
Eric Eastwood b60a39f260 Default CI variables to unprotected
See https://gitlab.com/gitlab-org/gitlab-ce/issues/42928
2018-02-09 12:18:43 -06:00
Eric Eastwood 332aa756d2 Refactor CI variable list code for usage with CI/CD settings page secret variables
Part of https://gitlab.com/gitlab-org/gitlab-ee/merge_requests/4110
2018-01-31 13:18:32 -06:00