Commit graph

13 commits

Author SHA1 Message Date
gfyoung
93a44e135b Add some frozen string to spec/**/*.rb
Adds frozen string to the following:

* spec/bin/**/*.rb
* spec/config/**/*.rb
* spec/controllers/**/*.rb

xref https://gitlab.com/gitlab-org/gitlab-ce/issues/59758
2019-04-15 10:17:05 +00:00
Frank Sauerburger
44d0d0e6f9
Fix broken links on help page
Update the help controller to correctly handle relative links on the help pages
when the relative link is before an external link on the same line in the
markdown file.

Test cases have been implement to check for
 - relative links before external link on same line,
 - HTTPS in query part of link,
 - URLs without '//' and
 - protocol-relative links.
2019-02-11 23:41:58 +01:00
blackst0ne
b44a2c801a Update specs to rails5 format
Updates specs to use new rails5 format.

The old format:
`get :show, { some: params }, { some: headers }`

The new format:
`get :show, params: { some: params }, headers: { some: headers }`
2018-12-19 10:04:31 +11:00
Mario de la Ossa
3581a78f81
Updating HelpController spec to use an existing image 2018-02-07 12:05:25 -06:00
Jacopo
2f40dac352 Refactor have_http_status into have_gitlab_http_status in the specs 2017-10-20 10:13:18 +02:00
Rémy Coutable
633538151b
Fix URL rewritting in the Help section
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-12-01 16:40:48 +01:00
David Wagner
c4ded595cc Fix broken external links in help/index.html
An external link was recently added but was broken because
'https://gitlab.com/help/' was prepended to every link in the page.

Since no link in the main help readme begins with "help" and since doing
so wouldn't make sense, the substitution conditionaly prepending "help"
can be simplified and reused.

Signed-off-by: David Wagner <david@marvid.fr>
2016-11-20 20:15:08 +01:00
Fu Xu
b99282804d fix error links in help page 2016-11-12 21:45:45 +08:00
Achilleas Pipinellis
b48fd097ff Fix failing spec on help controller 2016-07-22 11:49:09 +03:00
Connor Shea
16a8160e9f
Fix help page paths to make sure shortcuts and the UI help page work.
Add a test to make sure the help page UI path doesn't break in the future.

Fix #19972 and #19889.
2016-07-19 11:17:14 -06:00
Connor Shea
c30b325781
Fix failing tests. 2016-07-11 16:11:33 -06:00
Stan Hu
359ed48638 Fix Style/AlignHash cop violations 2015-06-22 22:24:39 -07:00
Robert Speicher
3052e89420 Re-fix image rendering for help pages 2015-04-15 12:45:31 -04:00