Commit graph

20 commits

Author SHA1 Message Date
GitLab Bot
dc003cd08b Add latest changes from gitlab-org/gitlab@master 2020-03-26 18:08:03 +00:00
GitLab Bot
619d0b6922 Add latest changes from gitlab-org/gitlab@master 2020-02-26 18:09:24 +00:00
GitLab Bot
22a0d312ae Add latest changes from gitlab-org/gitlab@master 2020-01-17 18:08:41 +00:00
GitLab Bot
f32a580aa1 Add latest changes from gitlab-org/gitlab@master 2020-01-13 18:08:05 +00:00
GitLab Bot
2a65a97e12 Add latest changes from gitlab-org/gitlab@master 2019-12-18 00:08:09 +00:00
DJ Mountney
0531a33889 Ensure attributes that end in _ids are cleaned
This prevents an issue where you can steal other projects objects by
asking for ids that don't belong to you in import.
2019-11-26 10:26:25 +01:00
George Koltsov
ec51240685 Add commit_id to AttributeCleaner::ALLOWED_REFERENCES 2019-07-15 10:30:39 +01:00
charlieablett
0aff6238f7 Change prohibited_key to use regexes 2019-05-01 12:15:29 +12:00
charlieablett
4b46b53082 Add html to sensitive words 2019-05-01 10:38:41 +12:00
charlieablett
1cbdc5326c Refactor attribute_cleaner for readability 2019-04-30 11:25:09 +12:00
charlieablett
b240012c4f Further clarify attribute_cleaner 2019-04-29 21:31:16 +12:00
charlieablett
4bd331a568 Tighten up prohibited_key method 2019-04-26 09:40:00 +12:00
Charlie Ablett
8eae788fd4 Use English instead of Latin 2019-04-25 09:39:53 +12:00
charlieablett
7e6befc05d Add disallowed fields to AttributeCleaner 2019-04-24 14:31:20 +12:00
gfyoung
7ec8af5017 Enable even more frozen string for lib/gitlab
Enables frozen string for the following:

* lib/gitlab/hook_data/**/*.rb
* lib/gitlab/i18n/**/*.rb
* lib/gitlab/import/**/*.rb
* lib/gitlab/import_export/**/*.rb
* lib/gitlab/kubernetes/**/*.rb
* lib/gitlab/legacy_github_import/**/*.rb
* lib/gitlab/manifest_import/**/*.rb
* lib/gitlab/metrics/**/*.rb
* lib/gitlab/middleware/**/*.rb

Partially addresses gitlab-org/gitlab-ce#47424.
2018-11-16 17:41:14 -08:00
Francisco Javier López
761d890a68
Blacklisting attributes in the project import process 2018-05-14 09:28:33 +02:00
Douwe Maan
cfb511ea69 Merge branch 'fix/import-projectmember-security' into 'security'
Fix Import/Export foreign key issue to do with project members

Cleans-up any foreign keys in `ProjectMember` - same as we do with the rest of the models when importing.

Fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/23837 and https://gitlab.com/gitlab-org/gitlab-ce/issues/23739

See merge request !2020

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-11-03 16:04:18 +01:00
James Lopez
891e5f4851 Update specs to cope with new label types and priorities
Fixed all related specs and also changed the logic to handle edge cases. This includes exporting and exporting of group labels, which will get associated with the new group (if any) or they will become normal project labels otherwise.

Found other issues to do with not being able to import all labels at once in the beginning of the JSON - code was much simpler when we import all labels and milestones associated to a project first, then the associations will find the already created labels instead of creating them from the associations themselves.
2016-10-19 14:58:28 -02:00
James Lopez
9e0b7c630f updated attribute cleaner to use allowed keyword and reject attributes 2016-09-27 16:12:08 +02:00
James Lopez
4c480be39b Prevent claiming associated model IDs via import and added relevant specs 2016-09-27 15:48:10 +02:00