Commit Graph

18 Commits

Author SHA1 Message Date
JB Vasseur 9f34083901 Remove useless braces !22296 2018-10-18 17:46:03 +09:00
JB Vasseur 6da9733652 Use ApplicationsFinder !22296 2018-10-18 09:43:35 +09:00
gfyoung 73322a0e55 Enable frozen string in app/controllers/**/*.rb
Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.
2018-09-18 21:22:45 -07:00
Yorick Peterse 2039c8280d
Disable existing offenses for the CodeReuse cops
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
2018-09-11 17:32:00 +02:00
James Lopez 9cb9a86f37 fix typo 2017-11-02 14:33:56 +01:00
James Lopez 32ef7ed7d6 fix specs 2017-11-02 13:14:56 +01:00
James Lopez 37eb00ce5b fix specs 2017-11-02 08:49:36 +01:00
James Lopez 232bdd47d9 refactor code 2017-10-31 09:03:59 +01:00
James Lopez 72b7b10d52 add applications controller logic 2017-10-31 09:03:59 +01:00
James Lopez 4a6ec7c947 refactor some controllers to make them EE friendly 2017-09-28 08:46:39 +02:00
Oswaldo Ferreira f837cd6611 Use params#require instead params[] access 2017-07-27 12:09:46 -04:00
Oswaldo Ferreira e561b142fa Backport gitlab-ee!2456 2017-07-27 12:09:46 -04:00
blackst0ne a544e46bb0 Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers 2017-06-07 09:45:16 +11:00
Markus Koller 789db2cc19 Make sure scopes are loaded in admin OAuth application form 2017-03-07 14:54:36 +01:00
Timothy Andrew 4d6da770de Implement minor changes from @dbalexandre's review.
- Mainly whitespace changes.

- Require the migration adding the `scope` column to the
  `personal_access_tokens` table to have downtime, since API calls will
  fail if the new code is in place, but the migration hasn't run.

- Minor refactoring - load `@scopes` in a `before_action`, since we're
  doing it in three different places.
2016-12-16 16:29:31 +05:30
Timothy Andrew 6c809dfae8 Allow creating personal access tokens / OAuth applications with scopes. 2016-12-16 15:08:10 +05:30
Dmitriy Zaporozhets a81081aa72 Small improvements to CI 2015-01-17 16:17:34 -08:00
Valery Sizov 20028523b5 Application admin scaffold 2015-01-17 15:40:09 -08:00