73322a0e55
Enable frozen string in app/controllers/**/*.rb
...
Enables frozen string for the following:
* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb
Partially addresses #47424 .
2018-09-18 21:22:45 -07:00
f0e7b5e7a3
Cleaned up CI runner administration code
...
In https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/19625 some
changes were introduced that do not meet our abstraction reuse rules.
This commit cleans up some of these changes so the requirements are met.
Most notably, sorting of the runners in Admin::RunnersFinder has been
delegated to Ci::Runner.order_by, similar to how we order data in
models that include the Sortable module. If we need more sort orders in
the future we can include Sortable and have Ci::Runner.order_by call
`super` to delegate to Sortable.order_by.
2018-09-14 15:05:46 +02:00
55c23a0935
Merge branch 'feature/runner-state-filter-for-admin-view' into 'master'
...
Feature: State filter for admin runners view
See merge request gitlab-org/gitlab-ce!19625
2018-09-14 09:03:44 +00:00
03890558b4
rename variable from *_cnt to *_count
2018-09-12 17:31:25 +02:00
2039c8280d
Disable existing offenses for the CodeReuse cops
...
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
2018-09-11 17:32:00 +02:00
34bdb74740
add sort dropdown to admin runners page
2018-08-29 15:02:54 +02:00
0a0350be00
extract filter/sort/paging logic to finder class
2018-08-20 17:15:11 +02:00
16d12491c5
add status filter to admin runners page
2018-08-20 17:15:11 +02:00
4ee08b77bc
Updates from `rubocop -a`
2018-07-09 21:13:08 +08:00
729f05f0e3
Adds Rubocop rule for line break around conditionals
2018-01-11 16:34:01 +00:00
6aff498426
Add sort runners on admin runners
2017-10-04 00:15:27 +09:00
a544e46bb0
Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers
2017-06-07 09:45:16 +11:00
7a109402a8
Prefer service object over after_save hook
...
Closes #26921
2017-01-21 02:18:14 +08:00
4cc77c3bf8
Minor runner-related code refactorings
2016-05-19 22:01:53 +02:00
52ba3a2d05
Display validation errors when admin edits a runner
2016-05-19 22:01:53 +02:00
7d6d3421d6
Share form editable attributes mf runner via model
2016-05-10 14:21:01 +02:00
e80e3f5372
Migrate CI::Project to Project
2015-12-11 18:02:09 +01:00
gfyoung