Commit graph

11 commits

Author SHA1 Message Date
gfyoung
15b878e27e Enable more frozen string in app/models/**/*.rb
Partially addresses #47424.
2018-08-07 00:37:36 -07:00
Sean McGivern
382421a9be Fix truncated_diff_lines for legacy notes without a line
It appears that some legacy diff notes on GitLab.com have invalid line codes,
which means truncated_diff_lines won't work. This is just a band-aid solution,
as neither the diff nor the discussion will display correctly for these notes,
but they won't cause a 500 error.
2018-01-30 15:17:44 +00:00
Douwe Maan
771bf9527f Improve performance of DiffDiscussion#truncated_diff_lines and DiffNote#diff_line by removing expensive diff position calculation and comparison 2017-12-22 18:07:15 +01:00
Douwe Maan
e4eba908cd Allow commenting on individual commits inside an MR 2017-12-07 09:01:19 -05:00
Felipe Artur
b54203f0ad Commenting on image diffs 2017-10-07 04:25:17 +00:00
Douwe Maan
0bf339f0ed Address review 2017-05-24 10:10:10 -05:00
Douwe Maan
f8fabfcc6f Allow commenting on older versions of the diff and comparisons between diff versions 2017-05-03 14:47:21 -05:00
Robert Speicher
58cd4c48e6 Fix NUMBER_OF_TRUNCATED_DIFF_LINES re-definition error 2017-04-12 13:59:35 -04:00
Douwe Maan
1817f877e1 Some code tweaks 2017-04-08 14:58:08 -05:00
Douwe Maan
c319f21141
Address review comments 2017-04-05 17:44:14 +01:00
Douwe Maan
2058e71e63
Extract commonalities between DiffDiscussion and LegacyDiffDiscussion 2017-04-05 17:44:14 +01:00