kotovalexarian-likes-gitlab/gitlab-org--gitlab-foss
1
0
Fork 0
Code Releases Activity
83659 commits 1 branch 0 tags 899 MiB
Commit graph

21 commits

Author SHA1 Message Date
gfyoung
be42c05054 Enable more frozen string in app/controllers/ 
Enables frozen string for the following:

* app/controllers/dashboard/**/*.rb
* app/controllers/explore/**/*.rb
* app/controllers/google_api/**/*.rb
* app/controllers/groups/**/*.rb
* app/controllers/import/**/*.rb
* app/controllers/instance_statistics/**/*.rb
* app/controllers/ldap/**/*.rb
* app/controllers/oauth/**/*.rb
* app/controllers/profiles/**/*.rb

Partially addresses #47424.
 2018-09-23 12:48:02 -07:00
🙈 jacopo beschi 🙉
c6b1043e9d Resolve "Make a Rubocop that forbids returning from a block" 2018-04-18 09:19:40 +00:00
Matija Čupić
05103f080c
Make Variable key not secret 2018-03-22 12:08:16 +01:00
Matija Čupić
53915c5c54
Alias secret_key and secret_value to key and value 2018-03-17 16:33:36 +01:00
Matija Čupić
28a5f8c60a
Use secret_key and secret_value in Variables controller 2018-03-16 16:56:42 +01:00
Bob Van Landuyt
148816cd67 Port read_cross_project ability from EE 2018-02-22 17:11:36 +01:00
Matija Čupić
efcdc269e0
Fix static_analysis failure 2018-02-06 17:56:54 +01:00
Matija Čupić
c95c3ffc9e
Switch emphasis from controller format to update 2018-02-05 18:58:20 +01:00
Matija Čupić
e2c8a2231b
Remove usage of VariablePresenter in controller 2018-02-05 18:58:20 +01:00
Matija Čupić
04263b9f3b
Add GroupVariableSerializer for Ci::GroupVariable 2018-02-05 18:58:20 +01:00
Matija Čupić
b48d8c8ad0
Return all variables after UPDATE 2018-02-05 18:58:19 +01:00
Matija Čupić
a8887a0d9c
Use resource in Group Variables routing scheme 2018-02-05 18:58:19 +01:00
Matija Čupić
6b82a9ef51
Format validation errors as human readable messages 2018-02-05 18:58:18 +01:00
Matija Čupić
bf2a040cf9
Pass validation errors in JSON endpoint 2018-02-05 18:58:18 +01:00
Matija Čupić
dcc23530bd
Remove redundant routes in Groups::VariablesController 2018-02-05 18:58:17 +01:00
Matija Čupić
cc2bed9283
Port #save_multiple to Groups::VariablesController 2018-02-05 18:58:17 +01:00
Shinya Maeda
3b2f09289f Name as variable_params like project variable controller 2017-07-07 17:14:29 +09:00
Shinya Maeda
8c434a52fc gb nice catches 2017-07-07 15:35:12 +09:00
Shinya Maeda
e255e4de69 ayufan nice catches 2017-07-07 15:35:12 +09:00
Shinya Maeda
2dd9a9af2f Fix variables_controller.rb and format 2017-07-07 15:35:12 +09:00
Shinya Maeda
5b0954759c Basic BE change 
Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Basic BE change

Fix static-snalysis

Move the precedence of group secure variable before project secure variable. Allow project_id to be null.

Separate Ci::VariableProject and Ci::VariableGroup

Add the forgotton files

Add migration file to update type of ci_variables

Fix form_for fpr VariableProject

Fix test

Change the table structure according to the yorik advice

Add necessary migration files. Remove unnecessary migration spec.

Revert safe_model_attributes.yml

Fix models

Fix spec

Avoid self.variable. Use becomes for correct routing.

Use unique index on group_id and key

Add null: false for t.timestamps

Fix schema version

Rename VariableProject and VariableGroup to ProjectVariable and GroupVariable

Rename the rest of them

Add the rest of files

Implement CURD

Rename codes related to VariableGroup and VariableProject FE part

Remove unneccesary changes

Make Fe code up-to-date

Add protected flag to migration file

Protected group variables essential package

Update schema

Improve doc

Fix logic and spec for models

Fix logic and spec for controllers

 Fix logic and spec for views(pre feature)

Add feature spec

Fixed bugs. placeholder. reveal button. doc.

Add changelog

Remove unnecessary comment

godfat nice catches

Improve secret_variables_for arctecture

Fix spec

Fix StaticAnlysys & path_regex spec

Revert "Improve secret_variables_for arctecture"

This reverts commit c3216ca212322ecf6ca534cb12ce75811a4e77f1.

Use ayufan suggestion for secret_variables_for

Use find instead of find_by

Fix spec message for variable is invalid

Fix spec remove variable.group_id = group.id

godffat spec nitpicks

Use include Gitlab::Routing.url_helpers for presenter spec
 2017-07-07 15:33:17 +09:00