Commit graph

12 commits

Author SHA1 Message Date
gfyoung
8184ce7fb7 Enable frozen in app/mailers/**/*.rb 2018-08-15 21:45:57 +00:00
Mario de la Ossa
eaada9d706 use Gitlab::UserSettings directly as a singleton instead of including/extending it 2018-02-02 18:39:55 +00:00
Sean McGivern
5883ce95ef current_application_settings belongs on Gitlab::CurrentSettings
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
2017-08-31 13:38:33 +01:00
Ruben Davila
5c921809cd Bugfix: Always use the default language when generating emails.
There was a race condition issue when the application was generating an
email and was using a language that was previously being used in other
request.
2017-05-25 10:22:45 -05:00
Toon Claes
d95bffc6da Rename GitlabMarkdownHelper -> MarkupHelper
It does more than solely GitLab Markdown, so rename to MarkupHelper.
2017-04-27 13:22:17 +02:00
mhasbini
0a09925dce Enable Style/Proc cop for rubocop 2017-04-02 12:48:43 +03:00
bogdanvlviv
2b4700b2be Use method helper instead of add_template_helper 2016-11-06 21:27:51 +02:00
http://jneen.net/
5853c96b49 remove Ability.abilities 2016-08-30 11:35:06 -07:00
Valery Sizov
7f214cee74 Migrate mailers to ActiveJob 2015-11-26 17:03:43 +02:00
Douwe Maan
eacdd5080a Fix Basemailer#can? 2015-08-19 14:58:41 -07:00
Douwe Maan
0bc94198fc Fix BaseMailer. 2015-08-19 12:51:42 -07:00
Douwe Maan
a8a861ae2a Add BaseMailer to house shared mailer functionality. 2015-08-19 12:35:08 -07:00