Commit graph

12 commits

Author SHA1 Message Date
Heinrich Lee Yu
a04d9ba90c Add reply to notes to turn into discussions 2019-02-06 10:31:46 +00:00
Heinrich Lee Yu
35b8f103a8
Prevent comments by email when issue is locked
This changes the permission check so it uses the policy on Noteable
instead of Project. This prevents bypassing of rules defined in
Noteable for locked discussions and confidential issues.

Also rechecks permissions when reply_to_discussion_id is provided since the
discussion_id may be from a different noteable.
2019-01-31 16:52:48 +01:00
Paul Slaughter
370f07361c Auto resolve new notes of resolved discussions
**Why?**

The previous behavior had resolved discussions being unresolved
when commented on. This was strange UX, especially since there
is a separate button for "Comment & unresolve discussion".

https://gitlab.com/gitlab-org/gitlab-ce/issues/24128

**Note:**

- Also adds changelog
2018-09-24 08:30:58 -05:00
gfyoung
fbde835404 Enable more frozen string in app/services/**/*.rb
Partially addresses #47424.
2018-07-17 15:19:40 -07:00
Jan Provaznik
dcdfa04b32 Add discussion API
* adds basic discussions API for issues and snippets
* reorganizes notes specs (so same tests can be used for all noteable types - issues, MRs, snippets)
2018-03-07 12:27:50 +01:00
Jarka Kadlecova
e4f7b87ddb Support comments for personal snippets 2017-05-05 15:45:49 +02:00
Douwe Maan
09330dd17c Remove unused code 2017-04-05 12:56:31 -05:00
Douwe Maan
c319f21141
Address review comments 2017-04-05 17:44:14 +01:00
Douwe Maan
bb8cc94668
Don't use original_discussion_id 2017-04-05 17:44:14 +01:00
Douwe Maan
874413cf70
Fix specs 2017-04-05 17:44:14 +01:00
Douwe Maan
79889a6aa3
Add specs 2017-04-05 17:44:14 +01:00
Douwe Maan
08bbb9fce6
Add option to start a new discussion on an MR 2017-04-05 17:44:14 +01:00