Commit Graph

11 Commits

Author SHA1 Message Date
Phil Hughes 3eedb2aede Refactored the user callout class
Instead of the JS being in charge of the HTML, the HAML now handles it.
The HAML can then check the cookie & show it needed. It also allows the
HAML access to the paths so we don't have to pass that through.

Closes #29955
2017-03-24 16:36:23 +00:00
Mike Greiling 9eae1812cd fix test failures 2017-03-22 13:02:51 -05:00
Mike Greiling 5f7c0bd7b7 remove Cookies class from global space 2017-03-22 03:07:27 -05:00
Simon Knox ea0520924f remove extra whitespace on dashboard projects page 2017-03-02 21:10:39 +00:00
Jose Ivan Vargas be18e70cd1 Corrected indentation on the template string
Also removed eslint disabled rules
2017-02-24 11:31:11 -06:00
Jose Ivan Vargas 2f681138dc Modified the user_callout behaviour
Now it appends a template instead of relying in a partial
to show it.
2017-02-23 15:47:23 -06:00
Jose Ivan Vargas 621bfdaa9f Removed disabled rules from the user_callout_spec.js
Also changed the cookie sets to true and false values to make
it consistent with the rest of the javascript.

Fixed some haml and a missing new line
2017-02-23 15:47:23 -06:00
Jose Ivan Vargas 46eefbda3a Moved the dismiss-icon listener to close the callout to a button 2017-02-23 15:47:23 -06:00
Jose Ivan Vargas bcab4bb5ef Changed the javascript class from using the global scope to exporting it via webpack
Also improved accesibility and change the id from user_callouts to a class
2017-02-23 15:47:23 -06:00
Jose Ivan Vargas 103f5a116b Created unit tests, fixtures and integration tests
Also changed the user_callout haml to a partial and
added the corresponding SVG icon
2017-02-23 15:47:23 -06:00
Jose Ivan Vargas 4802bd512a Initial version of the user-callouts 2017-02-23 15:47:23 -06:00