Commit graph

11 commits

Author SHA1 Message Date
Dylan Griffith
e7f2be49d8 Make KUBECONFIG nil if KUBE_TOKEN is nil
Having an invalid KUBECONFIG without a token in it is not helpful. This
only became possible recently now that we are creating a separate
namespace and service account (and hence token) to send to the runners.
This led to somewhat surprising results when troubleshooting
https://gitlab.com/gitlab-org/gitlab-ce/issues/53879 as I found that the
KUBECONFIG was still being passed but KUBE_TOKEN was not. These things
really should have been linked.

Furthermore now that we are also using the [presence of KUBECONFIG to
decide whether or not to run build steps in Auto
DevOps](294d15be3e/lib/gitlab/ci/templates/Auto-DevOps.gitlab-ci.yml (L164))
I think it makes even more sense to ensure that KUBECONFIG is a complete
config if passed to a job.
2018-11-30 11:03:42 +01:00
gfyoung
c858f70d07 Enable frozen string for lib/gitlab/*.rb 2018-10-22 07:00:50 +00:00
Nick Thomas
ca692fbcc1
Fix an exception seen using the online terminal 2018-07-11 15:44:34 +01:00
Alessio Caiazza
40c6128b39
Fix broken certificate-authority-data with kubectl >= 1.8.0 2017-10-03 09:10:40 +02:00
Lin Jen-Shin
dbb313c26f Encode certificate-authority-data in base64 2017-07-06 19:38:41 +08:00
Lin Jen-Shin
6fe2b79656 Fix rubocop offense 2017-06-16 23:17:06 +08:00
Lin Jen-Shin
07a65da1d9 Generate KUBECONFIG in KubernetesService#predefined_variables 2017-06-16 22:15:40 +08:00
Nick Thomas
fc6e3515a6 Backport EE changes to the Kubernetes service 2017-06-14 10:51:18 +01:00
Rémy Coutable
d40e1f547e Enable the Style/TrailingCommaInLiteral cop
Use the EnforcedStyleForMultiline: no_comma option.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-05-10 18:25:45 +02:00
Adam Niedzielski
5d3816652e Introduce maximum session time for terminal websocket connection
Store the value in application settings.
Expose the value to Workhorse.
2017-02-06 11:49:30 +01:00
Nick Thomas
c3d972f4e8 Add terminals to the Kubernetes deployment service 2016-12-19 19:53:04 +00:00