Lin Jen-Shin
4efc1c4a68
Rename according to:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12563922
For clarification and consistency
2016-06-20 16:52:05 +08:00
Lin Jen-Shin
8a0aeab846
Use active tense, feedback from:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12501303
2016-06-16 23:33:53 +08:00
Lin Jen-Shin
ae0e1e402e
blank line between setup and expectation, feedback:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093/diffs#note_12501266
and:
https://robots.thoughtbot.com/four-phase-test
2016-06-16 23:26:49 +08:00
Lin Jen-Shin
cd3f112f88
Adopt the rename from ci_commits to ci_pipelines
2016-06-15 17:34:44 +08:00
Lin Jen-Shin
cbd6ca6985
Rename specific_for to available_for:
...
Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12413950
2016-06-14 16:07:57 +08:00
Lin Jen-Shin
b0908d8739
Extra tests inside shared_examples:
...
Feedback from:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321421
The advantage of this is that tests are less about logic and more
straightforward, thus could be easier to reason about each individual
tests.
The disadvantage of this is that we write more duplicated codes and
once something changed we might need to change all places and it's
harder to reason all tests as a whole. Because now we need to look at
more places to figure out how it should work under another option!
2016-06-09 16:00:24 +08:00
Lin Jen-Shin
268f7713a9
Remove Build#can_be_served? and rename Runner#can_serve? to can_pick?
...
This also moves tests from build_spec.rb to runner_spec.rb
2016-06-09 16:00:24 +08:00
Lin Jen-Shin
de04004803
Prefer string for describe, feedback from:
...
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4093#note_12321029
2016-06-09 16:00:24 +08:00
Lin Jen-Shin
35954572b8
Prefer do and end for before/after:
...
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4404#note_12217415
2016-06-09 16:00:24 +08:00
Lin Jen-Shin
0eeb4bed49
Introduced Ci::Runner.specific_for for getting specific runners:
...
for a particular project.
2016-06-09 16:00:24 +08:00
Robert Speicher
75739e54be
Enable RSpec/NotToNot cop and auto-correct offenses
...
Also removes the note from the development/testing.md guide
2016-05-24 15:40:29 -04:00
Grzegorz Bizon
8252333183
Extend CI runners specs
2016-05-19 22:01:53 +02:00
Jeroen van Baarsen
f1479b56b7
Remove the annotate gem and delete old annotations
...
In 8278b763d9#17382
that it is better to get rid of the whole annotate gem, and instead let people
look at schema.rb for the columns in a table.
Fixes : #17382
2016-05-09 18:00:28 +02:00
Yorick Peterse
2076bdb62e
Use ILIKE/LIKE for searching CI runners
2016-03-11 15:25:21 -05:00
Tomasz Maczukin
49d5c35b69
Fix old usages of ci_runner factory
2016-02-19 13:18:49 +01:00
Kamil Trzcinski
64bfd9d71a
Remove ci_ prefix from all ci related things
2015-12-11 18:02:09 +01:00
Kamil Trzcinski
e80e3f5372
Migrate CI::Project to Project
2015-12-11 18:02:09 +01:00
Douwe Maan
1e8d703a85
Tag model specs
2015-12-09 10:50:51 +01:00
Dmitriy Zaporozhets
a237999f00
Annotate models
...
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2015-11-13 19:22:46 +01:00
Kamil Trzciński
daccc54d25
Merge branch 'builds-view' into 'master'
...
Added builds view
/cc @dzaporozhets @vsizov
See merge request !1593
2015-10-15 11:35:57 +00:00
Kamil Trzcinski
d9ece71ef0
Fix specs
2015-10-14 17:38:26 +02:00
Kamil Trzcinski
7af4f5215e
Show warning if build doesn't have runners with specified tags or runners didn't connect recently
...
Slightly refactor runner status detection: moving it to Runner class
Signed-off-by: Kamil Trzcinski <ayufan@ayufan.eu>
2015-10-14 17:29:18 +02:00
Valery Sizov
b87ca7500f
fix specs. Stage 7
2015-09-15 17:43:17 +03:00
Dmitriy Zaporozhets
59c3a3239f
Fix commit specs
2015-09-10 15:52:52 +02:00
Dmitriy Zaporozhets
10b3c85e2c
Fix some issues with ci models specs
2015-09-10 15:47:15 +02:00
Dmitriy Zaporozhets
cc4ef4da11
Refactor CI tests
2015-09-09 14:17:16 +02:00
