83adf64831
Fix rubocop violations
2019-01-31 21:31:25 +01:00
c653921b6f
Add subresources removal to member destroy service
2019-01-31 16:52:50 +01:00
1653f7b1c6
Delete confidential issue todos for guests
...
Fix leaking information of confidential issues on TODOs
when user is downgraded to guest access.
2018-12-14 10:38:52 -02:00
501fb04ec6
Delete todos when users loses target read permissions
2018-07-30 13:29:18 +02:00
a63bce1a4b
Resolve "Rename the `Master` role to `Maintainer`" Backend
2018-07-11 14:36:08 +00:00
4ee08b77bc
Updates from `rubocop -a`
2018-07-09 21:13:08 +08:00
74a24a4fab
Don't delete todos or unassign issues and MRs when a user leaves a project
2018-03-07 17:18:01 -06:00
1c88d92b3f
Improve Member services
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-02-27 16:02:22 +01:00
bf41063679
Remove explicit audit event log in MembershipActions
...
Move it to Members::ApproveAccessRequestService.
Also, note that there was a double audit event log for access request
destruction.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-02-27 16:02:22 +01:00
27c95364b5
Replace '.team << [user, role]' with 'add_role(user)' in specs
2017-12-22 19:18:28 +11:00
72a7b30c9f
Change all `:empty_project` to `:project`
2017-08-02 17:47:31 -04:00
ddccd24c13
Remove superfluous lib: true, type: redis, service: true, models: true, services: true, no_db: true, api: true
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-07-27 14:31:53 +02:00
0430b76441
Enable Style/DotPosition Rubocop 👮
2017-06-21 13:48:12 +00:00
ca9a79f620
Use `:empty_project` where possible in service specs
2017-03-27 20:44:09 -04:00
d211011698
Make access request specs explicitly enable or disable access requests as required
2016-11-11 15:45:47 +00:00
c8b1311934
Fix a few things after the initial improvment to Members::DestroyService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
3158f57dba
Improve Members::DestroyService
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-03 16:57:48 +02:00
654565c9dc
Raise a new Gitlab::Access::AccessDeniedError when permission is not enough to destroy a member
...
This is a try for a new approach to put the access checks at the service level.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 06:06:34 +02:00
a08a26ac81
Don't send the "access declined" email on access request withdrawal
...
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 05:46:45 +02:00
4652489f40
New Members::DestroyService
...
This is to ensure we don't send unwanted notifications when deleting a
project. In other words, stop abusing AR callbacks and use services.
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-06-18 05:46:45 +02:00
Gabriel Mazetto