Ash McKenzie
61111d4c0d
Bang up predicate methods and use #internal_route?
...
Extract internal route logic check out into #internal_route?
Add ? to #grack_route and #lfs_route predicate methods
2019-01-16 19:14:46 +11:00
Ash McKenzie
c0a5b628c8
Allow sidekiq admin requests, regardless of root
2019-01-16 19:14:46 +11:00
Stan Hu
aff2b6e4eb
Switch use of Rack::Request to ActionDispatch::Request
...
As mentioned in
https://gitlab.com/gitlab-org/gitlab-ee/issues/9035#note_129093444 ,
Rails 5 switched ActionDispatch::Request so that it no longer inherits
Rack::Request directly. A middleware that uses Rack::Request to
read the environment may see stale request parameters if
another middleware modifies the environment via ActionDispatch::Request.
To be safe, we should be using ActionDispatch::Request everywhere.
2019-01-07 00:35:53 -08:00
gfyoung
7ec8af5017
Enable even more frozen string for lib/gitlab
...
Enables frozen string for the following:
* lib/gitlab/hook_data/**/*.rb
* lib/gitlab/i18n/**/*.rb
* lib/gitlab/import/**/*.rb
* lib/gitlab/import_export/**/*.rb
* lib/gitlab/kubernetes/**/*.rb
* lib/gitlab/legacy_github_import/**/*.rb
* lib/gitlab/manifest_import/**/*.rb
* lib/gitlab/metrics/**/*.rb
* lib/gitlab/middleware/**/*.rb
Partially addresses gitlab-org/gitlab-ce#47424 .
2018-11-16 17:41:14 -08:00
Brett Walker
f3e1028371
Refactor rspec matchers in read_only_spec.rb
2018-07-07 04:22:44 +00:00
Ash McKenzie
26bea57883
Better route matching for read-only detection
2018-07-02 17:29:04 +10:00
Lin Jen-Shin
bb4fcb7809
Move constants and update for feedback
2018-03-03 00:39:42 +08:00
Lin Jen-Shin
5309d4457a
Put controller in its separate file
2018-02-07 22:56:07 +08:00
