Commit graph

19 commits

Author SHA1 Message Date
Andrew Newdigate
bb65cb1fd5 Remove healthchecks from prometheus endpoint 2018-07-12 17:37:51 +00:00
Zeger-Jan van de Weg
65840591cd
Gitaly metrics check for read/writeability
Prior to this change, health checks checked for writeability of the NFS
shards. Given we're moving away from that, this patch extends the checks
for Gitaly to check for read and writeability.

Potentially some dashboards will break, as over time these metrics will
no longer appear as Prometheus doesn't get the data anymore.
Observability in the circuit breaker will be reduced, but its not
expected to be turned on and the circuit breaker is being removed soon
too.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1218
2018-06-27 08:56:19 +02:00
Sean McGivern
cc058de8df Merge branch 'pawel/show_empty_page_when_prometheus_metrics_are_disabled-35639' into 'master'
Make Prometheus metrics endpoint return empty response when metrics are disabled

Closes #35639

See merge request gitlab-org/gitlab-ce!14490
2017-11-06 17:02:22 +00:00
Pawel Chojnacki
8a0e314463 Remove Filesystem check metrics that use too much CPU to handle requests 2017-11-02 09:55:42 -07:00
Pawel Chojnacki
1ea2a85cbe Make Prometheus metrics endpoint return empty response when metrics are disabled 2017-09-25 23:38:34 +02:00
Paweł Chojnacki
2c3d52161a Update Prometheus gem to version that explicitly calls munmap 2017-07-19 08:54:39 +00:00
Ben Kochie
86cbef4df4 Add unit to latency metrics.
Add `seconds` unit to latency metrics based on uptream naming
convention[0].

[0]: https://prometheus.io/docs/practices/naming/#metric-names
2017-07-12 14:48:46 +02:00
Sean McGivern
25d241ae97 Merge branch '33949-remove-healthcheck-access-token' into 'master'
Remove the need to use health check token by adding ability to whitelist hosts

Closes #33949

See merge request !12612
2017-07-11 08:51:27 +00:00
Paul Charlton
cb3b4a15e6 Support multiple Redis instances based on queue type 2017-07-11 03:35:47 +00:00
Pawel Chojnacki
2f875c4037 Finish refactring processed configuraiton, and add test validating ip range matching 2017-07-05 00:46:12 +02:00
Pawel Chojnacki
18521584bd Remove the need to use health check token
in favor of whitelist that will be used to
control the access to monitoring resources
2017-07-05 00:46:11 +02:00
Pawel Chojnacki
1c59ba67a5 Do not cleanup temp directory as this apparently causes silent rspec failures on linux in CI 2017-06-07 04:24:30 +02:00
Pawel Chojnacki
ae8f7666e5 Add prometheus text formatter
+ rename controler method to #index from #metrics
 + remove assertion from nullMetric
2017-06-02 19:45:58 +02:00
Pawel Chojnacki
c134a72cdb Move Prometheus presentation logic to PrometheusText
+ Use NullMetrics to mock metrics when unused
+ Use method_missing in NullMetrics mocking
+ Update prometheus gem to version that correctly uses transitive dependencies
+ Ensure correct folders are used in Multiprocess prometheus client tests.
+ rename Sessions controller's metric
2017-06-02 19:45:58 +02:00
Pawel Chojnacki
ef9f23b797 Mark migration as requiring no downtime
+ Add spaces for four phases approach
+ fix InfluxDB rename
2017-06-02 19:45:58 +02:00
Pawel Chojnacki
254830c1f9 Move most of MetricsController logic to MetricsService 2017-06-02 19:45:58 +02:00
Pawel Chojnacki
62fe37e3f8 move check if metrics are enabled to before action 2017-06-02 19:45:58 +02:00
Pawel Chojnacki
21561f3434 Correctly handle temporary folder for testing multiproces metrics 2017-06-02 19:45:58 +02:00
Pawel Chojnacki
0f4050430d Split metrics from health controller into metrics controller 2017-06-02 19:45:58 +02:00