Commit graph

5 commits

Author SHA1 Message Date
Mike Greiling
03b14b48a0 Resolve "Make project and features visibility settings less confusing" 2017-09-07 18:07:40 +00:00
Sean McGivern
5883ce95ef current_application_settings belongs on Gitlab::CurrentSettings
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
2017-08-31 13:38:33 +01:00
Robin Bobbitt
649d042dbc Add option to disable project export on instance 2017-08-11 12:22:37 -04:00
Robert Speicher
72a7b30c9f Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
Patricio Cano
7a9b545fb9 Added test that checks the correct select box is there for the LFS enabled setting. 2016-11-23 13:32:38 -06:00