Commit graph

22 commits

Author SHA1 Message Date
Douwe Maan
536a47b4b7 Merge branch 'sh-migrate-can-push-to-deploy-keys-projects-10-3' into 'security-10-3'
[10.3] Migrate `can_push` column from `keys` to `deploy_keys_project`

See merge request gitlab/gitlabhq!2276

(cherry picked from commit f6ca52d31bac350a23938e0aebf717c767b4710c)

1f2bd3c0 Backport to 10.3
2018-01-16 17:04:51 -08:00
Jacopo
2f40dac352 Refactor have_http_status into have_gitlab_http_status in the specs 2017-10-20 10:13:18 +02:00
Robert Schilling
915dd57fe2 Add tests for the unmodified header 2017-08-28 17:10:34 +02:00
Rémy Coutable
c946ee1282
Enable the Layout/SpaceBeforeBlockBraces cop
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-08-09 11:52:22 +02:00
Robert Speicher
72a7b30c9f Change all :empty_project to :project 2017-08-02 17:47:31 -04:00
Alexander Randa
c7bcebd56e Fix edit button for deploy keys available from other projects 2017-06-20 11:23:13 +00:00
Robert Speicher
a6ec5121f0 Correct RSpec/SingleLineHook cop offenses 2017-06-14 13:18:56 -05:00
Alexander Randa
3d70eeb5bb Implement ability to update deploy keys 2017-06-02 19:44:36 +03:00
Jacopo
ff76adb547 Unnecessary "include WaitForAjax" and "include ApiHelpers"
Removed all the unnecessary include of `WaitForAjax` and `ApiHelpers` in the specs.
Removed unnecessary usage of `api:true`
2017-04-21 22:32:02 +02:00
Mark Fletcher
4865a7ab92 Enable creation of deploy keys with write access via the API
* Documentation was incorrectly advertising the missing param
2017-04-05 16:22:28 +10:00
Robert Schilling
86c58687b2 Return 204 for delete endpoints 2017-02-28 08:32:38 +01:00
Robert Schilling
e7551214f3 API: Remove DELETE projects/:id/deploy_keys/:key_id/disable 2017-02-20 09:33:42 +01:00
Robert Schilling
c70dfbc686 Add a custom pagination matcher 2017-02-16 15:38:40 +01:00
Robert Schilling
18417c9ee8 Grapify all endpoints of the deploy keys API 2017-01-23 17:06:57 +01:00
Rémy Coutable
9c560b5cdf
Replace many :project with :empty_projects in API specs
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-01-17 11:41:27 -05:00
Rémy Coutable
4e249d5bae
Use :maximum instead of :within for length validators with a 0..N range
Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-12-06 10:23:17 +01:00
Livier
eb4f15571d Changed API spec files to describe the correct class
Restore changes for api spec files

Fix error in rspec Users

Delete extra space Repositories-spec
2016-11-28 10:55:27 -07:00
Joshua Welsh
ce4760bbd5
Fixes various errors when adding deploy keys caused by not exiting the control flow.
When adding a deploy key that already exists in the project the existing key would not be returned, resulting in an attempt to create a new one, which in turn caused a 500 error due to an ActiveRecord exception.

When adding a deploy key that exists within another project the key would be joined to the project, but would also attempt to create a new one, which resulted in a 400 error due to the key already existing.

Fixes #22741
Fixes #21754

Signed-off-by: Rémy Coutable <remy@rymai.me>
2016-10-26 12:54:47 +02:00
Z.J. van de Weg
554e18ab02 Create service for enabling deploy keys 2016-08-05 11:38:17 +02:00
Z.J. van de Weg
460065b743 Move deploy_key tests to deploy_key_spec.rb
Also, fix the failing test in the process
2016-08-04 16:55:20 +02:00
Z.J. van de Weg
2b6bd6a33f Use Grape DSL for deploy keys endpoints
Also a minor clean up of the post endpoint
2016-08-03 21:04:14 +02:00
Z.J. van de Weg
da3d3ba89c Endpoints to enable and disable deploy keys
Resolves #20123
2016-08-03 16:00:22 +02:00