Commit graph

16 commits

Author SHA1 Message Date
Rémy Coutable
47dd7d0bbe
Use gitlab-default_value_with Rails 5
This forks live at https://github.com/gitlabhq/default_value_for/tree/69-fix-action_controller-parameters-handling
and fixes an issue where default_value_for wouldn't handle
`ActionController::Parameters` correctly with Rails 5.

This fixes https://gitlab.com/gitlab-org/gitlab-ce/issues/54093.

Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-11-15 16:44:22 +01:00
Rémy Coutable
1f0502df0a
Fix a bug where internal email pattern wasn't respected
Signed-off-by: Rémy Coutable <remy@rymai.me>
2018-11-13 13:24:53 +01:00
Alexis Reigel
801fe04be7
allow users api to set public_email 2018-10-01 13:24:16 +02:00
Alexis Reigel
f38aa2bf30
add missing allowed attributes 2018-10-01 13:24:16 +02:00
Alexis Reigel
40cfd9e787
remove obsolete allowed attribute 2018-09-26 17:29:30 +02:00
Roger Rüttimann
93b9bfd93a Allow whitelisting for "external collaborator by default" setting 2018-08-30 12:53:06 +00:00
JX Terry
99011a61cf Add an option to have a private profile on GitLab 2018-07-24 12:46:19 +00:00
gfyoung
0cf45debb4 Enable more frozen string in app/services/**/*.rb
Partially addresses #47424.
2018-07-18 14:07:50 -07:00
Mario de la Ossa
eaada9d706 use Gitlab::UserSettings directly as a singleton instead of including/extending it 2018-02-02 18:39:55 +00:00
Markus Koller
257fd57134 Allow password authentication to be disabled entirely 2017-11-23 13:16:14 +00:00
Sean McGivern
5883ce95ef current_application_settings belongs on Gitlab::CurrentSettings
The initializers including this were doing so at the top level, so every object
loaded after them had a `current_application_settings` method. However, if
someone had rack-attack enabled (which was loaded before these initializers), it
would try to load the API, and fail, because `Gitlab::CurrentSettings` didn't
have that method.

To fix this:

1. Don't include `Gitlab::CurrentSettings` at the top level. We do not need
   `Object.new.current_application_settings` to work.
2. Make `Gitlab::CurrentSettings` explicitly `extend self`, as we already use it
   like that in several places.
3. Change the initializers to use that new form.
2017-08-31 13:38:33 +01:00
James Lopez
b33c638483 update code based on feedback 2017-06-23 17:11:31 +02:00
Rémy Coutable
aa54bb7e5a Fix logic in Users::CreateService broken by the fix for OAuth users
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-04-26 10:08:44 +02:00
Rémy Coutable
fa01c37359 Ensures that OAuth/LDAP/SAML users don't need to be confirmed
Signed-off-by: Rémy Coutable <remy@rymai.me>
2017-04-26 10:08:44 +02:00
Douwe Maan
d7e2ac7293 Fix OAuth, LDAP and SAML SSO when regular sign-ups are disabled 2017-04-24 19:27:39 -07:00
geoandri
defbff482d Implement Users::BuildService 2017-04-13 13:02:59 +03:00