Commit graph

5 commits

Author SHA1 Message Date
Ash McKenzie
9fc9ab2ba2 Add new GitlabDanger class
This class encapsulates our use of the Danger gem.
2019-09-06 11:21:53 +00:00
Ash McKenzie
f34e4545ec Revert "Merge branch '66596-allow-danger-to-be-run-locally' into 'master'"
This reverts merge request !32196
2019-09-06 07:14:30 +00:00
Ash McKenzie
70e1a17604
Update some Danger rules to not rely upon CI
Convert a bunch of Danger rules so they can run
locally.
2019-09-06 10:56:54 +10:00
Lukas Eipert
253e1818aa
Create helper to get all changed files
Danger apparently has three different objects which could contain files
you often want to check:

 - git.added_files
 - git.modified_files
 - git.renamed_files

The problem: If a file is renamed, `modified_files` contains the file
path before the rename. In some Danger checks we use `added_files` +
`modified_files`, which might contain the deleted paths of renamed
files, but missing the new paths of renamed files.

So we need to consider `renamed_files` as well.
2018-10-22 11:04:55 +02:00
Lukas Eipert
685d579472
Danger check for ignored eslint rules
We disabled a lot of eslint rules on a per-file basis. This checks
touched files for those and reminds you to re-enable the rules and fix
them.
2018-09-29 08:22:12 +02:00