Imre Farkas
8d900ade38
Remove PersonalAccessTokensFinder#find_by method
...
find_by_token is overriden by TokenAuthenticatable which can be easily
missed or confused with #find_by(:token) defined by ActiveRecord. First
step for safer usage is to remove #find_by.
2018-11-05 11:36:45 +01:00
Robert Speicher
c847f172d2
Merge branch 'fix_pat_auth-11-4' into 'security-11-4'
...
[11.4] Fix Token lookup for Git over HTTP and registry authentication
See merge request gitlab/gitlabhq!2577
2018-10-29 17:20:53 +01:00
Stan Hu
32b96bfd81
Merge branch 'frozen-string-app-finders-graphql' into 'master'
...
Enable frozen string in app/graphql + app/finders
See merge request gitlab-org/gitlab-ce!21681
2018-09-13 19:44:31 +00:00
gfyoung
47b3038434
Enable frozen string in app/graphql + app/finders
...
Partially addresses #47424 .
2018-09-11 12:15:23 -07:00
Yorick Peterse
2039c8280d
Disable existing offenses for the CodeReuse cops
...
This whitelists all existing offenses for the various CodeReuse cops, of
which most are triggered by the CodeReuse/ActiveRecord cop.
2018-09-11 17:32:00 +02:00
Jacopo
181cd299f9
Adds Rubocop rule for line break after guard clause
...
Adds a rubocop rule (with autocorrect) to ensure line break after guard clauses.
2017-11-16 17:58:29 +01:00
Tiago Botelho
005749a616
apply codestyle and implementation changes to the respective feature code
2017-03-06 19:18:26 +00:00
Tiago Botelho
2b474dc2b2
refactors finder and correlated code
2017-03-01 13:11:11 +00:00
Tiago Botelho
9f2e4742e3
applies relevant changes to the code and code structure
2017-02-28 22:15:40 +00:00
