Commit Graph

13 Commits

Author SHA1 Message Date
gfyoung 73322a0e55 Enable frozen string in app/controllers/**/*.rb
Enables frozen string for the following:

* app/controllers/*.rb
* app/controllers/admin/**/*.rb
* app/controllers/boards/**/*.rb
* app/controllers/ci/**/*.rb
* app/controllers/concerns/**/*.rb

Partially addresses #47424.
2018-09-18 21:22:45 -07:00
Lin Jen-Shin 4ee08b77bc Updates from `rubocop -a` 2018-07-09 21:13:08 +08:00
Kamil Trzciński c6e95b0440 Improve `Ci::Runner#assign_to` to return a flag whether it succeeded or not 2018-05-31 10:56:41 +02:00
blackst0ne a544e46bb0 Add a rubocop rule to check if a method 'redirect_to' is used without explicitly set 'status' in 'destroy' actions of controllers 2017-06-07 09:45:16 +11:00
Adam Pahlevi a0586dbc16 replace `find_with_namespace` with `find_by_full_path`
add complete changelog for !8949
2017-02-03 07:14:04 +07:00
Lin Jen-Shin 397a69f834 Allow admins to assign locked runners:
And show information about locked status.

Help! This looks bad :o
2016-06-28 19:55:12 +08:00
Lin Jen-Shin 95c99cd4fd Admin should be able to turn shared runners into specific ones:
The regression was introduced by:

1b8f52d920

I did that because there's a test specifying that a shared runner cannot
be enabled, in the API. So I assume that is the case for non-admin, but
admins should be able to do so anyway.

Also added a test to make sure this won't regress again.

Closes #19039
2016-06-28 13:46:47 +08:00
Lin Jen-Shin dbd534a853 Admin::RunnerProjectsController#index is not used 2016-06-17 21:12:58 +08:00
Lin Jen-Shin 314befded7 Fix typo. It's ivar and the column was called locked
Again! For admin.
2016-06-16 23:31:54 +08:00
Lin Jen-Shin 9cf45b0586 Return the association and check it in controller instead:
Feedback:
https://gitlab.com/gitlab-org/gitlab-ce/merge_requests/4641#note_12444891
2016-06-14 23:11:43 +08:00
Lin Jen-Shin 1b8f52d920 Avoid enabling locked runners. Give 403 in this case 2016-06-14 22:58:38 +08:00
Kamil Trzcinski 64bfd9d71a Remove ci_ prefix from all ci related things 2015-12-11 18:02:09 +01:00
Kamil Trzcinski e80e3f5372 Migrate CI::Project to Project 2015-12-11 18:02:09 +01:00