Commit graph

15 commits

Author SHA1 Message Date
Zeger-Jan van de Weg
a53a4a4309
Remove direct disk access in RemoveDotGitFromUsernames
Prior to this change, the migration touched the disk path. This has been
removed.

Further, I believe it also fixes a bug. It seems that GitLab Shell
checks if the root path exists, when the path is duplicated. For
example, if the shard is located at /home/git, it did check if
`/home/git/home/git` existed.
2018-07-19 15:19:45 +02:00
Jacob Vosmaer (GitLab)
5cf5680f9c Deny repository disk access in development and test 2018-06-14 11:18:25 +00:00
Zeger-Jan van de Weg
ec4423665c
Gitlab::Shell works on shard name, not path
Direct disk access is done through Gitaly now, so the legacy path was
deprecated. This path was used in Gitlab::Shell however. This required
the refactoring in this commit.

Added is the removal of direct path access on the project model, as that
lookup wasn't needed anymore is most cases.

Closes https://gitlab.com/gitlab-org/gitaly/issues/1111
2018-04-25 13:36:22 +02:00
Jacob Vosmaer
008a6a6ce6 Route path lookups through legacy_disk_path 2018-03-21 18:18:32 +01:00
Alejandro Rodríguez
0b9d56f960 Update storage settings to allow extra values per shard
This will be necessary when adding gitaly settings. This version
doesn't make any functional changes, but allows us to include this
breaking change in 9.0 and add the needed extra settings in the future
with backwards compatibility
2017-03-03 12:13:30 -03:00
James Lopez
5d619ab8e5 fix typo, added relevant spec 2017-01-16 16:11:50 +01:00
James Lopez
efea5e7096 fix typo 2017-01-16 13:39:57 +01:00
James Lopez
320cd7f364 fix var inside loop 2017-01-16 13:37:04 +01:00
James Lopez
40fe772279 fix bug in loop 2017-01-16 13:18:54 +01:00
James Lopez
9302fbd08c cope with namespace duplicated paths in any storage 2017-01-16 12:59:36 +01:00
James Lopez
a9402708b2 fix nil path error 2017-01-16 10:40:29 +01:00
James Lopez
7d03a55c98 Remove rollback and fixed a couple of issues 2017-01-16 09:49:58 +01:00
James Lopez
6cfaab3f76 Fix remove dot git migration failing when user has no projects
- Fixed typo
- Fixed migration when there are no projects and path is nil
- Added path rollback that was missing if there was a SQL error
2017-01-16 09:11:36 +01:00
James Lopez
0f84e747b0 Add check for new path existence 2017-01-13 09:15:52 +01:00
Dmitriy Zaporozhets
dbfac0de06
Rename users with namespace ending with .git
Signed-off-by: Dmitriy Zaporozhets <dmitriy.zaporozhets@gmail.com>
2016-12-26 16:14:41 +02:00